Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove AdaptiveCpp workaround in dpl_shim.h to allow for automatic pefetch #180

Conversation

illuhad
Copy link
Contributor

@illuhad illuhad commented Dec 4, 2023

To my knowledge, the AdaptiveCpp-specific workaround in dpl_shim.h is no longer necessary as the linking issue was fixed some time ago.

Additionally, this workaround prevents a new optmization in AdaptiveCpp stdpar from taking place: AdaptiveCpp stdpar can now emit automatic data prefetches. But this only works, if the data is managed by the stdpar runtime, which tracks pointers it knows. If sycl::malloc_shared is used directly, the stdpar optimizations do not recognize the pointer and won't apply the optimization.
(the reasoning being that if someone calls SYCL functionality directly, they might want to exert more control and emit prefetches or mem_advise operations by themselves).

Other projects which also use this header like cloverleaf are also affected. Will create a PR there too.

@illuhad
Copy link
Contributor Author

illuhad commented Dec 11, 2023

@tomdeakin Is this okay now? It addresses your feedback from #177.

@tomdeakin
Copy link
Contributor

Looks good, thanks @illuhad. As long as the CI comes back OK I'll merge. Thanks!

@illuhad
Copy link
Contributor Author

illuhad commented Jan 8, 2024

CI looks good to me @tomdeakin :)

@tomdeakin tomdeakin merged commit 1665a36 into UoB-HPC:develop Jan 8, 2024
5 checks passed
@illuhad illuhad deleted the hotfix/remove-adaptivecpp-stdpar-workaround branch January 9, 2024 00:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants