fix: improve false-positive Title elements on Chinese text #3836
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scanny
changed the title
scanny
force-pushed
the
scanny/fix-3084-chinese-titles
branch
from
d2b0d80 to
e5a3459
Compare
mrogers23458
approved these changes
Dec 17, 2024
scanny
force-pushed
the
scanny/fix-3084-chinese-titles
branch
from
3f5ab19 to
6119550
Compare
This pull request includes updated ingest test fixtures. Please review and merge if appropriate. Co-authored-by: scanny <scanny@users.noreply.github.com>
scanny
force-pushed
the
scanny/fix-3084-chinese-titles
branch
from
d170e2f to
915bceb
Compare
This pull request includes updated ingest test fixtures. Please review and merge if appropriate. Co-authored-by: scanny <scanny@users.noreply.github.com>
scanny
force-pushed
the
scanny/fix-3084-chinese-titles
branch
from
4082123 to
df4ff7a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Improve element-type mapping for Chinese text. Fixes bug where Chinese text would produce large numbers of false-positive
Titleelements.Fixes #3084