fix: ipv4 address regex #3808
Merged
fix: ipv4 address regex #3808
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The last test failed on changelog not being updated. My last commit ce5bf74 bumps the changelog. Let me know if this needs to be reverted. |
|
@cragwolfe Is there anything else you need from me? (Pinging you since you seem to be an active contributor for this project - apologies if I'm mistaken.) |
cragwolfe
approved these changes
Dec 7, 2024
There was a problem hiding this comment.
Looks good, however please update the version to be 0.16.11-dev0.
Thanks for the contribution, @praktiskt !
praktiskt
force-pushed
the
praktiskt/fix-ipv4-regex
branch
from
90d388c to
c1d47f8
Compare
|
@cragwolfe Done! Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed the ipv4 regex is wrong (it only capture one or two-digit octets, e.g.
n.nn.n.nn). Here's a correction and a bumped test for it.If you wish I can break out the ipv4 test to its own case, so we don't interfere with the existing
EMAIL_META_DATA_INPUTipv6 extraction test.Side note: The comment at
unstructured/nlp/patterns.py#95includes a bad ipv4 address example (last octet is wrongfully left-padded with a zero). I left it as it is because I'm not sure if the intention is to include "non-conventional" ipv4 addresses, like octal or hexadecimal octets.