-
Notifications
You must be signed in to change notification settings - Fork 827
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Migrate over fsspec connectors #3066
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rbiseck3
force-pushed
the
roman/migrate-fsspec-connectors
branch
from
May 21, 2024 19:09
5d3782b
to
7147d4c
Compare
rbiseck3
force-pushed
the
roman/migrate-fsspec-connectors
branch
from
June 3, 2024 13:26
e7786bc
to
660986f
Compare
rbiseck3
force-pushed
the
roman/migrate-fsspec-connectors
branch
from
June 4, 2024 15:28
b506d68
to
a877707
Compare
rbiseck3
force-pushed
the
roman/migrate-fsspec-connectors
branch
from
June 4, 2024 18:41
9203fab
to
bad381b
Compare
…3140) This pull request includes updated ingest test fixtures. Please review and merge if appropriate. Co-authored-by: rbiseck3 <rbiseck3@users.noreply.github.com>
…3141) This pull request includes updated ingest test fixtures. Please review and merge if appropriate. Co-authored-by: rbiseck3 <rbiseck3@users.noreply.github.com>
…3148) This pull request includes updated ingest test fixtures. Please review and merge if appropriate. Co-authored-by: rbiseck3 <rbiseck3@users.noreply.github.com>
rbiseck3
force-pushed
the
roman/migrate-fsspec-connectors
branch
from
June 5, 2024 17:56
bad381b
to
09cf404
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Move over all fsspec connectors to the new framework
Variety of bug fixes found and fixed in this PR as well:
InitVar
from being used in the root dataclass since this breaks serialization.