Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

version 0.0.80; bump to unstructured 0.15.10 #458

Merged
merged 6 commits into from
Sep 10, 2024
Merged

Conversation

MthwRobinson
Copy link
Contributor

Summary

Bumps to unstructured==0.15.10.

@MthwRobinson
Copy link
Contributor Author

Dockerfile test will be fixed once this is merged upstream in base-images

requirements/base.in Outdated Show resolved Hide resolved
@@ -601,7 +601,7 @@ def test_parallel_mode_preserves_uniqueness_of_hashes_when_assembling_pages_spli
response = client.post(
MAIN_API_ROUTE,
files=[("files", (str(test_file), open(test_file, "rb"), "application/pdf"))],
data={},
data={"chunking_strategy": "by_title", "new_after_n_chars": 500},
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@awalker4 - I get <Response [422 Unprocessable Entity]>.status_code when I use data={}, and the associated error message is below. When you explicitly set the params it complains about, the test works fine. Will check and see if any dependency bumps seem like they'd cause this.

ERROR    unstructured_api:app.py:44 [{'type': 'literal_error', 'loc': ['body', 'chunking_strategy'], 'msg': "Input should be 'by_title'", 'input': '', 'ctx': {'expected': "'by_title'"}}, {'type': 'int_parsing', 'lo
c': ['body', 'new_after_n_chars'], 'msg': 'Input should be a valid integer, unable to parse string as an integer', 'input': ''}]

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nothing jumps out unless it was the fastapi version bump. I'll give that a try quick to test.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed, the fastapi bump is what caused the failure. Works with fastapi==0.112.x and fastapi==0.113.x but not fastapi==0.114.x.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pinning to fastapi==0.113.0 for number to preserve behavior, but we should circle back on how to safely upgrade fastapi.

@MthwRobinson MthwRobinson enabled auto-merge (squash) September 10, 2024 19:30
@MthwRobinson MthwRobinson merged commit c52a2d1 into main Sep 10, 2024
6 checks passed
@MthwRobinson MthwRobinson deleted the release/0.0.80 branch September 10, 2024 20:01
@jsoref
Copy link
Contributor

jsoref commented Sep 12, 2024

When this merged, CI started failing ... https://github.com/Unstructured-IO/unstructured-api/actions/runs/10799719598

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants