This repository has been archived by the owner on Aug 27, 2018. It is now read-only.
Custom Permission Roles Support #57
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CyberiumShadow
suggested changes
Oct 29, 2016
| @@ -11,7 +11,9 @@ exports.init = (client) => { | |||
| // Load default configuration, create if not exist. | |||
| defaultConf = { | |||
| prefix: {type: "String", data: client.config.prefix}, | |||
| disabledCommands: {type: "Array", data: "[]"} | |||
| disabledCommands: {type: "Array", data: []}, | |||
| mod_role: {type: "String", data: "Mods"}, | |||
There was a problem hiding this comment.
Instead of hard coding Mods and Devs to be default
Why not default them as blank values?
| disabledCommands: {type: "Array", data: "[]"} | ||
| disabledCommands: {type: "Array", data: []}, | ||
| mod_role: {type: "String", data: "Mods"}, | ||
| admin_role: {type: "String", data: "Devs"} |
There was a problem hiding this comment.
Same thing with Line 16
| let member = guild.member(user); | ||
| let mod_role = guild.roles.find("name", "Mods"); | ||
| let mod_role = guild.roles.find("name", guildConf.mod_role); |
There was a problem hiding this comment.
Also like please use camelCase for modRole
| if (mod_role && member.roles.has(mod_role.id)) | ||
| permlvl = 2; | ||
| let admin_role = guild.roles.find("name", "Devs"); | ||
| let admin_role = guild.roles.find("name", guildConf.admin_role); |
|
@CyberiumShadow For the last 2 comments, followed snake case in the original Komada permissionLevel.js, and for why not defaulting them to undefined you could do that. but then whats the point of having a default configuration? It'd be like defaulting the prefix to "". Just my person opinion though. |
|
Fair enough |
CyberiumShadow
approved these changes
Oct 29, 2016
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for custom roles per server. Also fixes the disabledCommands to be an actual array as opposed to the string "[]". Made the custom roles two different strings so they could easily be edited with the conf core command, instead of dumping them into an object.