Skip to content
This repository has been archived by the owner on Aug 27, 2018. It is now read-only.

[BUGFIXES] More Bugfixes #122

Merged
merged 3 commits into from
Jan 23, 2017
Merged

[BUGFIXES] More Bugfixes #122

merged 3 commits into from
Jan 23, 2017

Conversation

UnseenFaith
Copy link
Owner

Proposed Semver Increment Bump: [MAJOR/MINOR/PATCH]

Patch

Changes Proposed in this Pull Request (List new items in CHANGELOG.MD)

  • Fixes for Help.js
  • Fixes for App.js accepting commands even without enough permission
  • Fixes for usage returning undefined due to race between resolve && forEach

(If Applicable) What Issue does it fix?

ditto

@CyberiumShadow CyberiumShadow merged commit 17229e5 into UnseenFaith:indev Jan 23, 2017
@UnseenFaith UnseenFaith deleted the More-Bug-Fixes branch January 27, 2017 00:59
CyberiumShadow added a commit that referenced this pull request Mar 15, 2017
* Bugfix: prefixMention undefined

When the ready event takes too long and a message event triggers before it executes, an error crashed the bot. This is now resolved (but prefix mentions are ignored until it's available)

* Event Logging (warn, error, disconnect)

Added logging for warn, error, and disconnect events emitted by discord.js

* msg.member.permLevel

Added permission level to msg.member so commands can do sub-checks (for example, a command with various actions with different permission levels)

* chore(package): update dependencies (#105)

https://greenkeeper.io/

* [BUGFIX] Fix function inits (#106)

* [BUG-FIX] Move Function init() to ready
SEMVER: PATCH

Why:

* Some function inits require cache to work properly

This change addresses the need by:

*  If a function's init() required something from a client collection, it failed to execute properly.
*  Moving init() functions the ready event seems like an appropriate workaround for now.

Fixes #106

* [PR] Bump Package.json
SEMVER:

Why:

* Package.json is being bumped by a semver patch increment

* Remove stupid comment

This damn "guild removed but not found" message has been plaguing me since I added confs.

* [FEATURE] New Configuration System (#107)

* [BUGFIX] Many Fixes/Additions (#108)

* Fixed Conf.js to use new Configuration System

* Changelog updated

* Events Added For Configuration System

* Clean function now properly removes client.user.email

* [FEATURE] Configuration Update (#110)

* Broke down Configuration into smaller, manageable parts.

* Changelog && Patch Bump

* [FEATURE] New Argument Prompting System (#111)

* New Argument Prompting System

* [PR] Changelog && Patch Bump

* [PR] Actual Patch Bump

* [PR] loadCommands fix

* [PR] Changelog - loadCommands

* [PR] Fix for My Idiotic Mistake

* [PR] Fix for My Idiotic Mistake

* [PR] Configuration Client Option to Disable Prompts

* [PR] Abort is now case-insensitive

* [PR] Fix for DMs

* [PR] Changelog for DMs

* [PR] Translation Fixed for DMs

* [PR] Config.prefix now accepts a String or an Array of Strings

* [PR] Reload.js Bugfix && Changelog Update

* [PR] Prefix.length error fixed

* [BUGFIX] Fixed Selfbot Prefix Mentioning Crashing with CMD Prompts (#112)

* Fixed Selfbot Prefix Mentioning Crashing with CMD Prompts

* [PR] Changelog

* Motiond3v/helpdm (#114)

* Help command is now a Direct Message

* Help command is now a Direct Message

* Update help.js

* Update package.json

* Fixed Bugs and Patch Bumped (#113)

* Fixed Bugs and Patch Bumped

* Update package.json

* Fixed selfbot's not being able to DM themselves (#115)

[BUG-FIX] Fixed selfbot's not being able to DM themselves

* [BUGFIXES] Bugfixes (#116)

* Bugfix && Changelog

* [PR] Reload.js Bug Fix

* [PR] Changelog

* [PR] Reload Clarification/Fix

* [PR] Patch Bump

* [PR] Cyber is a bish

* [NODE] Async/Await all the things (#117)

* Async/Await all the things

* Re-enabled disconnect event

* [PR] Fixed all commands that didnt have a usage

* [PR] New Initialize Function

* [PR] Fixed Wrong Shorthands

* [PR] Added Initialize Function to Changelog

* [BUG-FIX] More bug fixes (#118)

* Selfbot BugFixes

* [PR] New Download Command Linked to Pieces

* [PR] Changelog && Patch Bump

* [PR] Evies Changes

* [PR] Fixed spelling error

* [PR] Client.destroy() removed permanently.

* [PR] Changelog

* [PR] Features && Bug Fixes

* [PR] Help Command Fix

* [PR] Disable Typo Fixed

* [PR] Download Fix

* Download.js Fix (#120)

* Indev (#121)

* Download.js Fix

* Fixes

* No longer failed

* [BUGFIXES] More Bugfixes (#122)

* Bunch of Bugfixes

* [PR] Bunch of Command/inhibitor fixes

* ESLint お願いします

* [PR] Provider Requires

* [BUG-FIX] User Count now correctly displays. (#123)

SEMVER: Patch

Why:

* Allows Komada installations that do not fetchAllMembers to be able to
have an accurate user count..

* [BUG-FIX] Help Command is fixed
SEMVER: Patch

Why:

* A Fix to bring the Help Command back into working order

This change addresses the need by:

* Changing the buildHelp code from `msg.author.permlvl` to
`msg.member.permlvl`

* Removal of console.log(params)

* [BUG-FIX] Prompts & Help (#124)

* Prompts Fix

* [PR] Msg.member.permLevel -> msg.author.permLevel

* [PR] Changelog for Prompts

* More AwaitMessage/Prompt Fixes

* [PR] Priority Fix for Inhibs

* [PR] Cmd.Rejected

* [PR] Fix for cmd.Rejected

* [PR] .some() Change

* [PR] Eslint Disable

* [BUG-FIX] Lotsa Bugs (#125)

* Prompts Fix

* [PR] Msg.member.permLevel -> msg.author.permLevel

* [PR] Changelog for Prompts

* More AwaitMessage/Prompt Fixes

* [PR] Priority Fix for Inhibs

* [PR] Cmd.Rejected

* [PR] Fix for cmd.Rejected

* [PR] .some() Change

* [PR] Eslint Disable

* Events Crucial Fix

* [PR] Fixed Event Loading (#126)

* [PR] Fixed Event Loading

* Update CHANGELOG.md

* Update package.json

* You've encountered a wild Buggerfree! (#127)

* You encountered a lone Buggerfree.

* You saw nothing Faith

* [BUG-FIX] Fixes Dep Installation on Client Functions
SEMVER: N/A

* Extended help (#128)

* Extended Help added

* [PR] Inhibitors changed to await

* [PR] Usage Spell checking

* [PR] Bump && Changelog

* Potential Inhib fix (#129)

* Inhibitor Fix (#130)

* Inhibitor Fix

* Removed useless async

* [PR] Help Fix

* [Feature] New Command &  Inhibitor (#131)

* [FEATURE] Transfer Command Added
SEMVER: N/A

Why:

* A transfer command that copies "pieces" from Core directories to
client directories has been added.

* [FEATURE] Added runIn Inhibitor
SEMVER:
Minor
Why:

* This now allows a better variety in how/where commands can be run

This change addresses the need by:

* changing the boolean-based guildOnly property
to an array of channel types

* Sounds better

* Removal of Async/Await... not working properly (#132)

* [FEATURE] New error handling && Command Handler (#133)

* New Errors && Command Handlers.. and other stuff

* [PR] Minor Bump && Changelog

* [PR] Changelog && uncaughtPromise fix

* [PR] Fix for Client being undefined

* [PR] Update README

* Holy fuck Depth: 5 are you kidding me?

* [BUGFIX] Fixes dem nasty Empty Message errors.

* [BUGFIX] Refer to previous commit

Refer to #347

* [BUGFIX] Refer to #347

Refer to #347

* [BUGFIX] Error fixing (#134)

* Fix for Cmd Prompts && Revert of Log.js

* [PR] Changelog && Patch Bump

* Features (#135)

* One Super Big Commit

* [PR] Eslinting

* [PR] Jsdocing of Config Types && Config.js

* [PR] More jsdocing

* [BUGFIXES] Merge Indev (#136)

* Bugfixes, Whoopsies

* Changelog Updated

* [FEATURES] Destruction of App.js (#137)

* The Destruction of App.js

* [PR] Changelog && Patch Bump

* [PR] Eslint && Array-prefixing fix

* [BUGFIXES] Reload && Events (#139)

* Bugfixes && Changes

* [PR] Patch Bump

* Revert "[BUGFIXES] Reload && Events" (#140)

* [BUG FIXES] Reload && Events && Inits (#141)

* Bugfixes && Changes

* [PR] Patch Bump

* Continuation of #141

* Continuation of #141 Part 2

* [BUGFIX] Initialisation is now fixed.

* [BUG-FIX] Booleans are now properly validated

* Fixed some typos in parseUsage (#142)

* Fixed some typos

* Update parseUsage.js

* CHANGELOG

* Bump to 0.18.0
CyberiumShadow added a commit that referenced this pull request Mar 17, 2017
* Bugfix: prefixMention undefined

When the ready event takes too long and a message event triggers before it executes, an error crashed the bot. This is now resolved (but prefix mentions are ignored until it's available)

* Event Logging (warn, error, disconnect)

Added logging for warn, error, and disconnect events emitted by discord.js

* msg.member.permLevel

Added permission level to msg.member so commands can do sub-checks (for example, a command with various actions with different permission levels)

* chore(package): update dependencies (#105)

https://greenkeeper.io/

* [BUGFIX] Fix function inits (#106)

* [BUG-FIX] Move Function init() to ready
SEMVER: PATCH

Why:

* Some function inits require cache to work properly

This change addresses the need by:

*  If a function's init() required something from a client collection, it failed to execute properly.
*  Moving init() functions the ready event seems like an appropriate workaround for now.

Fixes #106

* [PR] Bump Package.json
SEMVER:

Why:

* Package.json is being bumped by a semver patch increment

* Remove stupid comment

This damn "guild removed but not found" message has been plaguing me since I added confs.

* [FEATURE] New Configuration System (#107)

* [BUGFIX] Many Fixes/Additions (#108)

* Fixed Conf.js to use new Configuration System

* Changelog updated

* Events Added For Configuration System

* Clean function now properly removes client.user.email

* [FEATURE] Configuration Update (#110)

* Broke down Configuration into smaller, manageable parts.

* Changelog && Patch Bump

* [FEATURE] New Argument Prompting System (#111)

* New Argument Prompting System

* [PR] Changelog && Patch Bump

* [PR] Actual Patch Bump

* [PR] loadCommands fix

* [PR] Changelog - loadCommands

* [PR] Fix for My Idiotic Mistake

* [PR] Fix for My Idiotic Mistake

* [PR] Configuration Client Option to Disable Prompts

* [PR] Abort is now case-insensitive

* [PR] Fix for DMs

* [PR] Changelog for DMs

* [PR] Translation Fixed for DMs

* [PR] Config.prefix now accepts a String or an Array of Strings

* [PR] Reload.js Bugfix && Changelog Update

* [PR] Prefix.length error fixed

* [BUGFIX] Fixed Selfbot Prefix Mentioning Crashing with CMD Prompts (#112)

* Fixed Selfbot Prefix Mentioning Crashing with CMD Prompts

* [PR] Changelog

* Motiond3v/helpdm (#114)

* Help command is now a Direct Message

* Help command is now a Direct Message

* Update help.js

* Update package.json

* Fixed Bugs and Patch Bumped (#113)

* Fixed Bugs and Patch Bumped

* Update package.json

* Fixed selfbot's not being able to DM themselves (#115)

[BUG-FIX] Fixed selfbot's not being able to DM themselves

* [BUGFIXES] Bugfixes (#116)

* Bugfix && Changelog

* [PR] Reload.js Bug Fix

* [PR] Changelog

* [PR] Reload Clarification/Fix

* [PR] Patch Bump

* [PR] Cyber is a bish

* [NODE] Async/Await all the things (#117)

* Async/Await all the things

* Re-enabled disconnect event

* [PR] Fixed all commands that didnt have a usage

* [PR] New Initialize Function

* [PR] Fixed Wrong Shorthands

* [PR] Added Initialize Function to Changelog

* [BUG-FIX] More bug fixes (#118)

* Selfbot BugFixes

* [PR] New Download Command Linked to Pieces

* [PR] Changelog && Patch Bump

* [PR] Evies Changes

* [PR] Fixed spelling error

* [PR] Client.destroy() removed permanently.

* [PR] Changelog

* [PR] Features && Bug Fixes

* [PR] Help Command Fix

* [PR] Disable Typo Fixed

* [PR] Download Fix

* Download.js Fix (#120)

* Indev (#121)

* Download.js Fix

* Fixes

* No longer failed

* [BUGFIXES] More Bugfixes (#122)

* Bunch of Bugfixes

* [PR] Bunch of Command/inhibitor fixes

* ESLint お願いします

* [PR] Provider Requires

* [BUG-FIX] User Count now correctly displays. (#123)

SEMVER: Patch

Why:

* Allows Komada installations that do not fetchAllMembers to be able to
have an accurate user count..

* [BUG-FIX] Help Command is fixed
SEMVER: Patch

Why:

* A Fix to bring the Help Command back into working order

This change addresses the need by:

* Changing the buildHelp code from `msg.author.permlvl` to
`msg.member.permlvl`

* Removal of console.log(params)

* [BUG-FIX] Prompts & Help (#124)

* Prompts Fix

* [PR] Msg.member.permLevel -> msg.author.permLevel

* [PR] Changelog for Prompts

* More AwaitMessage/Prompt Fixes

* [PR] Priority Fix for Inhibs

* [PR] Cmd.Rejected

* [PR] Fix for cmd.Rejected

* [PR] .some() Change

* [PR] Eslint Disable

* [BUG-FIX] Lotsa Bugs (#125)

* Prompts Fix

* [PR] Msg.member.permLevel -> msg.author.permLevel

* [PR] Changelog for Prompts

* More AwaitMessage/Prompt Fixes

* [PR] Priority Fix for Inhibs

* [PR] Cmd.Rejected

* [PR] Fix for cmd.Rejected

* [PR] .some() Change

* [PR] Eslint Disable

* Events Crucial Fix

* [PR] Fixed Event Loading (#126)

* [PR] Fixed Event Loading

* Update CHANGELOG.md

* Update package.json

* You've encountered a wild Buggerfree! (#127)

* You encountered a lone Buggerfree.

* You saw nothing Faith

* [BUG-FIX] Fixes Dep Installation on Client Functions
SEMVER: N/A

* Extended help (#128)

* Extended Help added

* [PR] Inhibitors changed to await

* [PR] Usage Spell checking

* [PR] Bump && Changelog

* Potential Inhib fix (#129)

* Inhibitor Fix (#130)

* Inhibitor Fix

* Removed useless async

* [PR] Help Fix

* [Feature] New Command &  Inhibitor (#131)

* [FEATURE] Transfer Command Added
SEMVER: N/A

Why:

* A transfer command that copies "pieces" from Core directories to
client directories has been added.

* [FEATURE] Added runIn Inhibitor
SEMVER:
Minor
Why:

* This now allows a better variety in how/where commands can be run

This change addresses the need by:

* changing the boolean-based guildOnly property
to an array of channel types

* Sounds better

* Removal of Async/Await... not working properly (#132)

* [FEATURE] New error handling && Command Handler (#133)

* New Errors && Command Handlers.. and other stuff

* [PR] Minor Bump && Changelog

* [PR] Changelog && uncaughtPromise fix

* [PR] Fix for Client being undefined

* [PR] Update README

* Holy fuck Depth: 5 are you kidding me?

* [BUGFIX] Fixes dem nasty Empty Message errors.

* [BUGFIX] Refer to previous commit

Refer to #347

* [BUGFIX] Refer to #347

Refer to #347

* [BUGFIX] Error fixing (#134)

* Fix for Cmd Prompts && Revert of Log.js

* [PR] Changelog && Patch Bump

* Features (#135)

* One Super Big Commit

* [PR] Eslinting

* [PR] Jsdocing of Config Types && Config.js

* [PR] More jsdocing

* [BUGFIXES] Merge Indev (#136)

* Bugfixes, Whoopsies

* Changelog Updated

* [FEATURES] Destruction of App.js (#137)

* The Destruction of App.js

* [PR] Changelog && Patch Bump

* [PR] Eslint && Array-prefixing fix

* [BUGFIXES] Reload && Events (#139)

* Bugfixes && Changes

* [PR] Patch Bump

* Revert "[BUGFIXES] Reload && Events" (#140)

* [BUG FIXES] Reload && Events && Inits (#141)

* Bugfixes && Changes

* [PR] Patch Bump

* Continuation of #141

* Continuation of #141 Part 2

* [BUGFIX] Initialisation is now fixed.

* [BUG-FIX] Booleans are now properly validated

* Fixed some typos in parseUsage (#142)

* Fixed some typos

* Update parseUsage.js

* CHANGELOG

* Bump to 0.18.0

* [BUGFIX/Feature] Fixed Event Loading && Added Internal Utils (#143)

* Moved loading to Utils

* Time for more utils

* FML

* Faith fixed the regex

* Typo out of 10

* regexp

* Fixed Configs

* ESlint

* temp

* ^^^^

* typo

* We are not using initialize function again

* Client.ready

* Added Env Var support for clientDir

* Removal of client.email from clean function

* ESlint + Updating of ~Info Command

* ...

* Fix a typo on line 70 (#144)

[FIX] Fix a typo on line 70

* reload all commands

* whoops

* Silent inhibitors (#146)

* Added silent inhibitors

If you have an inhibitor and you set `return true;`, it'll stop execution instead of sending an error. However, you are still able to do `return "This is a string"`, and it'll reply with the inserted string.

* Added Silent Inhibitors

* Update handleCommand.js

* Update package.json

* Fixed

* Added the new Discord.js methods. (#147)

* Update package.json

* Update CHANGELOG.md

* Added new Discord.js utils

* Update .travis.yml

* Sentry integration

* Update app.js

* grrr

* Is this it?

* ESLint

* Update package.json

* Update CHANGELOG.md

* Update package.json

* Fixed reload events

* Update CHANGELOG.md

* Fixed `'file' is not defined`

* ESLint

* Update package.json

* Update app.js

* Update package.json

* Update CHANGELOG.md

* ESLint

* Fixed codeblocks and missing information (no error stack)

* Fixed missing codeblocks

* Update CHANGELOG.md

* Add error.stack to case warn.

* Disconnect event should print "Disconnected" now

* Update CHANGELOG.md

* Update app.js

* util.inspect error, warn, and better disconnect message.

* Update CHANGELOG.md

* Update app.js

* Oops
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants