Added support for super-wildcards. #11
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged in an old patch from the CodeModel JIRA (https://java.net/jira/browse/CODEMODEL-11) to support things like generics like <? super A>. Also changed some Javadoc to get it to build the archives on my system. And a small change to the build.gradle to switch to a SNAPSHOT build and to get it to work without authenticator properties.
…nto the syntax tree
|
So, first of all, thanks for putting these together! There's a lot of great changes here. My only concern is that there are so many of them, and some seem pretty unrelated. I'd like to give each of these their time to shine, so what I'll probably do is break these into separate branches and make new pulls which we can work on. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merged in an old patch from the CodeModel JIRA (https://java.net/jira/browse/CODEMODEL-11) to support generics like <? super A>.
Also changed some Javadoc to get it to build the archives on my system. I can take them out of the commit if they are not appreciated, but I think most of them are improvements (except maybe the parts where I deleted stuff^^).
I had to do a few small change to the build.gradle to switch to a SNAPSHOT build and to get it to work without authenticator properties. I don't know much about gradle, so if you have a better/preferred way of handling this, let me know and I'll fix it.