Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve next-plugin-preval configuration by disabling it in development + improve layouts #341

Merged
merged 11 commits into from
May 27, 2021
Merged

Improve next-plugin-preval configuration by disabling it in development + improve layouts #341

merged 11 commits into from
May 27, 2021

Conversation

Vadorequest
Copy link
Member

@Vadorequest Vadorequest commented May 27, 2021 •
edited
Loading

  • Disable "next-plugin-preval" in development
  • Improve core layout (customizability++)
  • Add SSR page template for public layout
  • Refactor/add quickPreview layout

@github-actions github-actions bot temporarily deployed to customer1-staging May 27, 2021 14:37 Inactive
@github-actions github-actions bot temporarily deployed to storybook May 27, 2021 14:37 Inactive
@github-actions
Copy link

✅  Deployment SUCCESS
Commit 2c3b84e successfully deployed Next.js app 🚀 to https://nrn-v2-mst-aptd-at-lcz-sty-c1-3moz2quit-unly-oss.vercel.app
Deployment aliases (2): nrn-v2-mst-aptd-at-lcz-sty-c1-preview.vercel.app, nrn-v2-mst-aptd-at-lcz-sty-c1-improve-preval.vercel.app

@github-actions
Copy link

✅  Deployment SUCCESS
Commit 2c3b84e successfully deployed Storybook static site 📖 to https://nrn-v2-mst-aptd-at-lcz-sty-storybook-59ttoq9qi-unly-oss.vercel.app
Deployment aliases (1): nrn-v2-mst-aptd-at-lcz-sty-storybook.vercel.app

@github-actions
Copy link

✅  E2E tests SUCCESS for commit 2c3b84e previously deployed Storybook static site at https://nrn-v2-mst-aptd-at-lcz-sty-storybook-59ttoq9qi-unly-oss.vercel.app

@github-actions github-actions bot temporarily deployed to customer1-staging May 27, 2021 14:48 Inactive
@github-actions github-actions bot temporarily deployed to storybook May 27, 2021 14:48 Inactive
@github-actions
Copy link

✅  E2E tests SUCCESS for commit 2c3b84e previously deployed at https://nrn-v2-mst-aptd-at-lcz-sty-c1-3moz2quit-unly-oss.vercel.app

@github-actions
Copy link

✅  Deployment SUCCESS
Commit e476c67 successfully deployed Next.js app 🚀 to https://nrn-v2-mst-aptd-at-lcz-sty-c1-gn0rsxnd4-unly-oss.vercel.app
Deployment aliases (2): nrn-v2-mst-aptd-at-lcz-sty-c1-preview.vercel.app, nrn-v2-mst-aptd-at-lcz-sty-c1-improve-preval.vercel.app

@github-actions
Copy link

✅  Deployment SUCCESS
Commit e476c67 successfully deployed Storybook static site 📖 to https://nrn-v2-mst-aptd-at-lcz-sty-storybook-cfmt05iiq-unly-oss.vercel.app
Deployment aliases (1): nrn-v2-mst-aptd-at-lcz-sty-storybook.vercel.app

@github-actions
Copy link

✅  E2E tests SUCCESS for commit e476c67 previously deployed at https://nrn-v2-mst-aptd-at-lcz-sty-c1-gn0rsxnd4-unly-oss.vercel.app

@github-actions
Copy link

✅  E2E tests SUCCESS for commit e476c67 previously deployed Storybook static site at https://nrn-v2-mst-aptd-at-lcz-sty-storybook-cfmt05iiq-unly-oss.vercel.app

@github-actions github-actions bot temporarily deployed to customer1-staging May 27, 2021 15:06 Inactive
@github-actions github-actions bot temporarily deployed to storybook May 27, 2021 15:09 Inactive
@github-actions github-actions bot temporarily deployed to customer1-staging May 27, 2021 15:09 Inactive
@github-actions
Copy link

✅  Deployment SUCCESS
Commit 3dd6f87 successfully deployed Next.js app 🚀 to https://nrn-v2-mst-aptd-at-lcz-sty-c1-lr2e1r7p3-unly-oss.vercel.app
Deployment aliases (2): nrn-v2-mst-aptd-at-lcz-sty-c1-preview.vercel.app, nrn-v2-mst-aptd-at-lcz-sty-c1-improve-preval.vercel.app

@github-actions
Copy link

✅  E2E tests SUCCESS for commit 3dd6f87 previously deployed at https://nrn-v2-mst-aptd-at-lcz-sty-c1-lr2e1r7p3-unly-oss.vercel.app

@github-actions
Copy link

✅  Deployment SUCCESS
Commit d6573c4 successfully deployed Next.js app 🚀 to https://nrn-v2-mst-aptd-at-lcz-sty-c1-qg7dr4qa8-unly-oss.vercel.app
Deployment aliases (2): nrn-v2-mst-aptd-at-lcz-sty-c1-preview.vercel.app, nrn-v2-mst-aptd-at-lcz-sty-c1-improve-preval.vercel.app

@github-actions
Copy link

✅  Deployment SUCCESS
Commit d6573c4 successfully deployed Storybook static site 📖 to https://nrn-v2-mst-aptd-at-lcz-sty-storybook-91k7rkt3p-unly-oss.vercel.app
Deployment aliases (1): nrn-v2-mst-aptd-at-lcz-sty-storybook.vercel.app

@github-actions
Copy link

✅  E2E tests SUCCESS for commit d6573c4 previously deployed at https://nrn-v2-mst-aptd-at-lcz-sty-c1-qg7dr4qa8-unly-oss.vercel.app

@github-actions
Copy link

✅  E2E tests SUCCESS for commit d6573c4 previously deployed Storybook static site at https://nrn-v2-mst-aptd-at-lcz-sty-storybook-91k7rkt3p-unly-oss.vercel.app

@github-actions github-actions bot temporarily deployed to customer1-staging May 27, 2021 15:44 Inactive
@github-actions
Copy link

✅  Deployment SUCCESS
Commit 3716c43 successfully deployed Next.js app 🚀 to https://nrn-v2-mst-aptd-at-lcz-sty-c1-mdv6705ub-unly-oss.vercel.app
Deployment aliases (2): nrn-v2-mst-aptd-at-lcz-sty-c1-preview.vercel.app, nrn-v2-mst-aptd-at-lcz-sty-c1-improve-preval.vercel.app

@github-actions
Copy link

✅  E2E tests SUCCESS for commit 3716c43 previously deployed at https://nrn-v2-mst-aptd-at-lcz-sty-c1-mdv6705ub-unly-oss.vercel.app

@github-actions github-actions bot temporarily deployed to customer1-staging May 27, 2021 16:00 Inactive
@github-actions
Copy link

✅  Deployment SUCCESS
Commit 703a29a successfully deployed Next.js app 🚀 to https://nrn-v2-mst-aptd-at-lcz-sty-c1-qgkdi7zd1-unly-oss.vercel.app
Deployment aliases (2): nrn-v2-mst-aptd-at-lcz-sty-c1-preview.vercel.app, nrn-v2-mst-aptd-at-lcz-sty-c1-improve-preval.vercel.app

@github-actions
Copy link

✅  E2E tests SUCCESS for commit 703a29a previously deployed at https://nrn-v2-mst-aptd-at-lcz-sty-c1-qgkdi7zd1-unly-oss.vercel.app

@github-actions github-actions bot temporarily deployed to storybook May 27, 2021 16:13 Inactive
@github-actions
Copy link

✅  Deployment SUCCESS
Commit ed30d7b successfully deployed Storybook static site 📖 to https://nrn-v2-mst-aptd-at-lcz-sty-storybook-hcgyxpnse-unly-oss.vercel.app
Deployment aliases (1): nrn-v2-mst-aptd-at-lcz-sty-storybook.vercel.app

@github-actions
Copy link

✅  E2E tests SUCCESS for commit ed30d7b previously deployed Storybook static site at https://nrn-v2-mst-aptd-at-lcz-sty-storybook-hcgyxpnse-unly-oss.vercel.app

@Vadorequest Vadorequest marked this pull request as ready for review May 27, 2021 16:25
@Vadorequest Vadorequest merged commit e1263f4 into v2-mst-aptd-at-lcz-sty May 27, 2021
@Vadorequest Vadorequest deleted the improve-preval branch May 27, 2021 16:25
@Vadorequest Vadorequest restored the improve-preval branch May 27, 2021 16:26
@Vadorequest Vadorequest deleted the improve-preval branch May 27, 2021 16:26
@Vadorequest Vadorequest restored the improve-preval branch May 27, 2021 16:26
@Vadorequest Vadorequest deleted the improve-preval branch May 27, 2021 16:26
@Vadorequest Vadorequest restored the improve-preval branch May 27, 2021 16:26
@github-actions github-actions bot temporarily deployed to storybook May 27, 2021 16:27 Inactive
@github-actions github-actions bot temporarily deployed to customer1-staging May 27, 2021 16:27 Inactive
Vadorequest added a commit that referenced this pull request May 27, 2021
@Vadorequest
Various stuff from #341
0ed6348
@Vadorequest Vadorequest mentioned this pull request May 27, 2021
Merged
@Vadorequest Vadorequest deleted the improve-preval branch May 27, 2021 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Vadorequest