Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pre-fetch all Locize translations as app-wide static data #337

Merged
merged 3 commits into from
May 26, 2021
Merged

Pre-fetch all Locize translations as app-wide static data #337

merged 3 commits into from
May 26, 2021

Conversation

Vadorequest
Copy link
Member

@Vadorequest Vadorequest commented May 26, 2021 •
edited
Loading

Similar to #335 and #336, but for Locize instead of Airtable/GraphCMS.

Similar benefits:

  • Cost reduction (less API calls, which are on-demand billed)
  • Faster build time (less API calls, 1 per lang instead of 1 per lang per page), which are slow (even if we had a caching mechanism)
  • Possible to read translations from the API (wasn't possible before, unless fetching the translation again)
  • Preview mode is backward compatible, we fetch the actual translations in preview mode (same behavior as SSR)

@github-actions github-actions bot temporarily deployed to customer1-staging May 26, 2021 22:46 Inactive
@Vadorequest Vadorequest changed the title Rename getSharedAirtableDataset > getStaticAirtableDataset / etc. Pre-fetch all Locize translations as app-wide static data May 26, 2021
@github-actions
Copy link

✅  Deployment SUCCESS
Commit ed0d13e successfully deployed Next.js app 🚀 to https://nrn-v2-mst-aptd-at-lcz-sty-c1-gcoomoc5n-unly-oss.vercel.app
Deployment aliases (2): nrn-v2-mst-aptd-at-lcz-sty-c1-preview.vercel.app, nrn-v2-mst-aptd-at-lcz-sty-c1-prefetch-static-locize.vercel.app

@github-actions
Copy link

✅  E2E tests SUCCESS for commit ed0d13e previously deployed at https://nrn-v2-mst-aptd-at-lcz-sty-c1-gcoomoc5n-unly-oss.vercel.app

@Vadorequest Vadorequest marked this pull request as ready for review May 26, 2021 22:57
@Vadorequest Vadorequest merged commit 0900fc7 into v2-mst-aptd-at-lcz-sty May 26, 2021
@Vadorequest Vadorequest deleted the prefetch-static-locize branch May 26, 2021 22:57
This was referenced May 26, 2021
Merged
Closed
Vadorequest added a commit that referenced this pull request May 26, 2021
@Vadorequest
Pre-fetch all Locize translations as app-wide static data (GCMS), bas…
ec7f95a 
…ed on #337 (#338)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Vadorequest