Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix rel="alternate" - Must use absolute url (with "https://" prefix) #321

Merged
merged 6 commits into from
May 11, 2021
Merged

Fix rel="alternate" - Must use absolute url (with "https://" prefix) #321

merged 6 commits into from
May 11, 2021

Conversation

Vadorequest
Copy link
Member

@Vadorequest Vadorequest commented May 10, 2021 •
edited
Loading

See GoogleChrome/lighthouse#12458 (comment)

Issue: Not sure how to get the hostname, not available there, would need to be provided from getStaticProps? (but that wouldn't be a valid host name if generated at build time), not sure how to do that.

Solution: Use VERCEL_URL env variable that's injected during build, and make it available to the whole app.

@github-actions
Copy link

✅  Deployment SUCCESS
Commit 0192f0c successfully deployed Next.js app 🚀 to https://nrn-v2-mst-aptd-gcms-lcz-sty-c1-crnb4b47y-unly-oss.vercel.app
Deployment aliased as

@github-actions
Copy link

✅  Deployment SUCCESS
Commit 0192f0c successfully deployed Storybook static site 📖 to https://nrn-v2-mst-aptd-gcms-lcz-sty-storybook-mntrq7cni-unly-oss.vercel.app
Deployment aliased as nrn-v2-mst-aptd-gcms-lcz-sty-storybook

@github-actions
Copy link

✅  E2E tests SUCCESS for commit 0192f0c previously deployed Storybook static site at https://nrn-v2-mst-aptd-gcms-lcz-sty-storybook-mntrq7cni-unly-oss.vercel.app

@github-actions
Copy link

✅  E2E tests SUCCESS for commit 0192f0c previously deployed at https://nrn-v2-mst-aptd-gcms-lcz-sty-c1-crnb4b47y-unly-oss.vercel.app

@github-actions github-actions bot temporarily deployed to customer1-staging May 11, 2021 05:17 Inactive
@github-actions github-actions bot temporarily deployed to storybook May 11, 2021 05:17 Inactive
@github-actions github-actions bot temporarily deployed to storybook May 11, 2021 05:21 Inactive
@github-actions github-actions bot temporarily deployed to customer1-staging May 11, 2021 05:21 Inactive
@github-actions
Copy link

✅  Deployment SUCCESS
Commit 6d6b052 successfully deployed Next.js app 🚀 to https://nrn-v2-mst-aptd-gcms-lcz-sty-c1-o5vhr2vbo-unly-oss.vercel.app
Deployment aliased as

@github-actions
Copy link

✅  Deployment SUCCESS
Commit 6d6b052 successfully deployed Storybook static site 📖 to https://nrn-v2-mst-aptd-gcms-lcz-sty-storybook-q6mrl556v-unly-oss.vercel.app
Deployment aliased as nrn-v2-mst-aptd-gcms-lcz-sty-storybook

@github-actions
Copy link

✅  E2E tests SUCCESS for commit 6d6b052 previously deployed at https://nrn-v2-mst-aptd-gcms-lcz-sty-c1-o5vhr2vbo-unly-oss.vercel.app

@github-actions
Copy link

✅  E2E tests SUCCESS for commit 6d6b052 previously deployed Storybook static site at https://nrn-v2-mst-aptd-gcms-lcz-sty-storybook-q6mrl556v-unly-oss.vercel.app

@github-actions
Copy link

✅  Deployment SUCCESS
Commit 2791ce6 successfully deployed Next.js app 🚀 to https://nrn-v2-mst-aptd-gcms-lcz-sty-c1-gxrl5pna3-unly-oss.vercel.app
Deployment aliased as

@github-actions
Copy link

✅  Deployment SUCCESS
Commit 2791ce6 successfully deployed Storybook static site 📖 to https://nrn-v2-mst-aptd-gcms-lcz-sty-storybook-4u6yxqbo6-unly-oss.vercel.app
Deployment aliased as nrn-v2-mst-aptd-gcms-lcz-sty-storybook

@github-actions
Copy link

✅  E2E tests SUCCESS for commit 2791ce6 previously deployed at https://nrn-v2-mst-aptd-gcms-lcz-sty-c1-gxrl5pna3-unly-oss.vercel.app

@github-actions
Copy link

✅  E2E tests SUCCESS for commit 2791ce6 previously deployed Storybook static site at https://nrn-v2-mst-aptd-gcms-lcz-sty-storybook-4u6yxqbo6-unly-oss.vercel.app

@github-actions github-actions bot temporarily deployed to storybook May 11, 2021 05:41 Inactive
@github-actions github-actions bot temporarily deployed to customer1-staging May 11, 2021 05:41 Inactive
@github-actions
Copy link

✅  Deployment SUCCESS
Commit 1f4f1ed successfully deployed Next.js app 🚀 to https://nrn-v2-mst-aptd-gcms-lcz-sty-c1-4odu6sful-unly-oss.vercel.app
Deployment aliased as

@github-actions
Copy link

✅  Deployment SUCCESS
Commit 1f4f1ed successfully deployed Storybook static site 📖 to https://nrn-v2-mst-aptd-gcms-lcz-sty-storybook-4s6cuu9cz-unly-oss.vercel.app
Deployment aliased as nrn-v2-mst-aptd-gcms-lcz-sty-storybook

@github-actions
Copy link

✅  E2E tests SUCCESS for commit 1f4f1ed previously deployed at https://nrn-v2-mst-aptd-gcms-lcz-sty-c1-4odu6sful-unly-oss.vercel.app

@github-actions
Copy link

✅  E2E tests SUCCESS for commit 1f4f1ed previously deployed Storybook static site at https://nrn-v2-mst-aptd-gcms-lcz-sty-storybook-4s6cuu9cz-unly-oss.vercel.app

@github-actions github-actions bot temporarily deployed to storybook May 11, 2021 06:05 Inactive
@github-actions github-actions bot temporarily deployed to customer1-staging May 11, 2021 06:05 Inactive
@github-actions
Copy link

✅  Deployment SUCCESS
Commit ac40f7d successfully deployed Next.js app 🚀 to https://nrn-v2-mst-aptd-gcms-lcz-sty-c1-4d6r7bz2p-unly-oss.vercel.app
Deployment aliased as

@github-actions
Copy link

✅  Deployment SUCCESS
Commit ac40f7d successfully deployed Storybook static site 📖 to https://nrn-v2-mst-aptd-gcms-lcz-sty-storybook-gxwyct275-unly-oss.vercel.app
Deployment aliased as nrn-v2-mst-aptd-gcms-lcz-sty-storybook

@github-actions
Copy link

✅  E2E tests SUCCESS for commit ac40f7d previously deployed at https://nrn-v2-mst-aptd-gcms-lcz-sty-c1-4d6r7bz2p-unly-oss.vercel.app

@github-actions
Copy link

✅  E2E tests SUCCESS for commit ac40f7d previously deployed Storybook static site at https://nrn-v2-mst-aptd-gcms-lcz-sty-storybook-gxwyct275-unly-oss.vercel.app

@github-actions github-actions bot temporarily deployed to storybook May 11, 2021 06:28 Inactive
@github-actions github-actions bot temporarily deployed to customer1-staging May 11, 2021 06:28 Inactive
@Vadorequest Vadorequest marked this pull request as ready for review May 11, 2021 06:34
@github-actions
Copy link

✅  Deployment SUCCESS
Commit 24a86ea successfully deployed Next.js app 🚀 to https://nrn-v2-mst-aptd-gcms-lcz-sty-c1-h5kty4aak-unly-oss.vercel.app
Deployment aliased as

@github-actions
Copy link

✅  Deployment SUCCESS
Commit 24a86ea successfully deployed Storybook static site 📖 to https://nrn-v2-mst-aptd-gcms-lcz-sty-storybook-k06vvjyzn-unly-oss.vercel.app
Deployment aliased as nrn-v2-mst-aptd-gcms-lcz-sty-storybook

@github-actions
Copy link

✅  E2E tests SUCCESS for commit 24a86ea previously deployed Storybook static site at https://nrn-v2-mst-aptd-gcms-lcz-sty-storybook-k06vvjyzn-unly-oss.vercel.app

@github-actions
Copy link

✅  E2E tests SUCCESS for commit 24a86ea previously deployed at https://nrn-v2-mst-aptd-gcms-lcz-sty-c1-h5kty4aak-unly-oss.vercel.app

@Vadorequest Vadorequest merged commit d1ddd27 into v2-mst-aptd-gcms-lcz-sty May 11, 2021
@Vadorequest Vadorequest deleted the fix-rel-alternate branch May 11, 2021 06:41
Vadorequest added a commit that referenced this pull request May 11, 2021
@Vadorequest
Fix rel="alternate" - Must use absolute url (with "https://" prefix) (#…
4117bcb 
…321)

* Add todo

* Print VERCEL_URL for debug

* Print NEXT_PUBLIC_VERCEL_URL for debug

* Try to expose VERCEL_URL (+ enabled auto exposure from vercel project)

* Add VERCEL_DOMAIN and NEXT_PUBLIC_APP_BASE_URL env vars

* Use NEXT_PUBLIC_APP_BASE_URL + add env vars doc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Vadorequest