Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rework of fonts #315

Merged
merged 6 commits into from
May 10, 2021
Merged

Rework of fonts #315

merged 6 commits into from
May 10, 2021

Conversation

Vadorequest
Copy link
Member

@Vadorequest Vadorequest commented May 9, 2021 •
edited
Loading

Current NRN Fonts implementation has a few issues:

  • No browser caching, fonts are downloaded at every refresh
  • FOUT effect (text's size changes between initial render and once the font has been loaded) AKA "swap" strategy
  • Using external lib WebFontLoader which increase complexity (not obvious how it works)

Inspiration

https://twitter.com/leeerob/status/1345554813375938561

Code examples:

Doc:

Resources:

What's done

@github-actions github-actions bot temporarily deployed to customer1-staging May 9, 2021 16:13 Inactive
@github-actions github-actions bot temporarily deployed to storybook May 9, 2021 16:13 Inactive
@github-actions
Copy link

github-actions bot commented May 9, 2021

✅  Deployment SUCCESS
Commit 3c5fa2e successfully deployed Next.js app 🚀 to https://nrn-v2-mst-aptd-at-lcz-sty-c1-lyv6nhm0z-unly-oss.vercel.app
Deployment aliased as

@github-actions
Copy link

github-actions bot commented May 9, 2021

✅  Deployment SUCCESS
Commit 3c5fa2e successfully deployed Storybook static site 📖 to https://nrn-v2-mst-aptd-at-lcz-sty-storybook-zdiq5v6g0-unly-oss.vercel.app
Deployment aliased as nrn-v2-mst-aptd-at-lcz-sty-storybook

@github-actions
Copy link

github-actions bot commented May 9, 2021

✅  E2E tests SUCCESS for commit 3c5fa2e previously deployed at https://nrn-v2-mst-aptd-at-lcz-sty-c1-lyv6nhm0z-unly-oss.vercel.app

@github-actions
Copy link

github-actions bot commented May 9, 2021

✅  E2E tests SUCCESS for commit 3c5fa2e previously deployed Storybook static site at https://nrn-v2-mst-aptd-at-lcz-sty-storybook-zdiq5v6g0-unly-oss.vercel.app

@Vadorequest
Self-host fonts instead of using Google Fonts + remove NeuzeitGrotesk…
3234f9c 
… (not open-source) + add utilities to manage fonts + add documentation about how to add a new (Variable) Font + handle customer font (fallback to default font)
@github-actions github-actions bot temporarily deployed to customer1-staging May 9, 2021 21:19 Inactive
@github-actions github-actions bot temporarily deployed to storybook May 9, 2021 21:19 Inactive
@github-actions
Copy link

github-actions bot commented May 9, 2021

✅  Deployment SUCCESS
Commit 3234f9c successfully deployed Next.js app 🚀 to https://nrn-v2-mst-aptd-at-lcz-sty-c1-mgu1yndpx-unly-oss.vercel.app
Deployment aliased as

@github-actions
Copy link

github-actions bot commented May 9, 2021

✅  Deployment SUCCESS
Commit 3234f9c successfully deployed Storybook static site 📖 to https://nrn-v2-mst-aptd-at-lcz-sty-storybook-k652squwv-unly-oss.vercel.app
Deployment aliased as nrn-v2-mst-aptd-at-lcz-sty-storybook

@github-actions
Copy link

github-actions bot commented May 9, 2021

✅  E2E tests SUCCESS for commit 3234f9c previously deployed at https://nrn-v2-mst-aptd-at-lcz-sty-c1-mgu1yndpx-unly-oss.vercel.app

@github-actions
Copy link

github-actions bot commented May 9, 2021

✅  E2E tests SUCCESS for commit 3234f9c previously deployed Storybook static site at https://nrn-v2-mst-aptd-at-lcz-sty-storybook-k652squwv-unly-oss.vercel.app

@github-actions github-actions bot temporarily deployed to storybook May 9, 2021 22:20 Inactive
@github-actions github-actions bot temporarily deployed to customer1-staging May 9, 2021 22:20 Inactive
@github-actions
Copy link

github-actions bot commented May 9, 2021

✅  Deployment SUCCESS
Commit c132409 successfully deployed Next.js app 🚀 to https://nrn-v2-mst-aptd-at-lcz-sty-c1-jj7hh7qnp-unly-oss.vercel.app
Deployment aliased as

@github-actions
Copy link

github-actions bot commented May 9, 2021

✅  Deployment SUCCESS
Commit c132409 successfully deployed Storybook static site 📖 to https://nrn-v2-mst-aptd-at-lcz-sty-storybook-i1mmm4eul-unly-oss.vercel.app
Deployment aliased as nrn-v2-mst-aptd-at-lcz-sty-storybook

@github-actions github-actions bot temporarily deployed to storybook May 9, 2021 22:28 Inactive
@github-actions github-actions bot temporarily deployed to customer1-staging May 9, 2021 22:28 Inactive
@Vadorequest Vadorequest mentioned this pull request May 9, 2021
Closed
@Vadorequest Vadorequest linked an issue May 9, 2021 that may be closed by this pull request
Full rework of how fonts are handled #316
Closed
@github-actions
Copy link

github-actions bot commented May 9, 2021

✅  E2E tests SUCCESS for commit c132409 previously deployed Storybook static site at https://nrn-v2-mst-aptd-at-lcz-sty-storybook-i1mmm4eul-unly-oss.vercel.app

@github-actions
Copy link

github-actions bot commented May 9, 2021

✅  E2E tests SUCCESS for commit c132409 previously deployed at https://nrn-v2-mst-aptd-at-lcz-sty-c1-jj7hh7qnp-unly-oss.vercel.app

@github-actions
Copy link

github-actions bot commented May 9, 2021

✅  Deployment SUCCESS
Commit b0665bf successfully deployed Next.js app 🚀 to https://nrn-v2-mst-aptd-at-lcz-sty-c1-etdwsbcuf-unly-oss.vercel.app
Deployment aliased as

@github-actions
Copy link

github-actions bot commented May 9, 2021

✅  Deployment SUCCESS
Commit b0665bf successfully deployed Storybook static site 📖 to https://nrn-v2-mst-aptd-at-lcz-sty-storybook-8hlcnz19o-unly-oss.vercel.app
Deployment aliased as nrn-v2-mst-aptd-at-lcz-sty-storybook

@github-actions
Copy link

github-actions bot commented May 9, 2021

✅  E2E tests SUCCESS for commit b0665bf previously deployed at https://nrn-v2-mst-aptd-at-lcz-sty-c1-etdwsbcuf-unly-oss.vercel.app

@github-actions
Copy link

github-actions bot commented May 9, 2021

✅  E2E tests SUCCESS for commit b0665bf previously deployed Storybook static site at https://nrn-v2-mst-aptd-at-lcz-sty-storybook-8hlcnz19o-unly-oss.vercel.app

@github-actions github-actions bot temporarily deployed to customer1-staging May 10, 2021 08:25 Inactive
@github-actions github-actions bot temporarily deployed to storybook May 10, 2021 08:25 Inactive
@github-actions
Copy link

✅  Deployment SUCCESS
Commit c8c0f89 successfully deployed Next.js app 🚀 to https://nrn-v2-mst-aptd-at-lcz-sty-c1-3te8yieey-unly-oss.vercel.app
Deployment aliased as

@github-actions
Copy link

✅  Deployment SUCCESS
Commit c8c0f89 successfully deployed Storybook static site 📖 to https://nrn-v2-mst-aptd-at-lcz-sty-storybook-npffngq9b-unly-oss.vercel.app
Deployment aliased as nrn-v2-mst-aptd-at-lcz-sty-storybook

@github-actions
Copy link

✅  E2E tests SUCCESS for commit c8c0f89 previously deployed Storybook static site at https://nrn-v2-mst-aptd-at-lcz-sty-storybook-npffngq9b-unly-oss.vercel.app

@github-actions
Copy link

✅  E2E tests SUCCESS for commit c8c0f89 previously deployed at https://nrn-v2-mst-aptd-at-lcz-sty-c1-3te8yieey-unly-oss.vercel.app

@Vadorequest Vadorequest merged commit 5779939 into v2-mst-aptd-at-lcz-sty May 10, 2021
@Vadorequest Vadorequest deleted the rework-fonts branch May 10, 2021 09:09
Vadorequest added a commit that referenced this pull request May 10, 2021
@Vadorequest
Rework of fonts (#315)
2dd5a0e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Full rework of how fonts are handled
1 participant
@Vadorequest