Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add "Jest" addon for Storybook #262

Merged
merged 3 commits into from
Jan 17, 2021
Merged

Add "Jest" addon for Storybook #262

merged 3 commits into from
Jan 17, 2021

Conversation

Vadorequest
Copy link
Member

@Vadorequest Vadorequest commented Jan 17, 2021 •
edited
Loading

Doesn't seem to work locally, but works online.

Open a Vercel deployment (e.g: https://nrn-v2-mst-aptd-at-lcz-sty-storybook-r8pkm78xe.vercel.app/) and open the AirtableAsset component preview. It works well. (but not locally)

Opened storybookjs/storybook#13621

Status:

Works fine on both localhost and production. No idea what fixed it (big changes since the initial issue)

@Vadorequest
Add @storybook/addon-jest + test AirtableAsset.stories.tsx (doesn't w…
d9404ee 
…ork) + change "yarn test" scripts to generate an output
@Vadorequest Vadorequest mentioned this pull request Jan 17, 2021
Closed
@github-actions
Copy link

✅  Deployment SUCCESS
Commit d9404ee successfully deployed Storybook static site to https://nrn-v2-mst-aptd-at-lcz-sty-storybook-9xmlcvx6t.vercel.app
Deployment aliased as nrn-v2-mst-aptd-at-lcz-sty-storybook

@github-actions
Copy link

✅  E2E tests SUCCESS for commit d9404ee previously deployed Storybook static site at https://nrn-v2-mst-aptd-at-lcz-sty-storybook-9xmlcvx6t.vercel.app

@github-actions
Copy link

✅  Deployment SUCCESS
Commit d9404ee successfully deployed to https://nrn-v2-mst-aptd-at-lcz-sty-c1-qhxbt0kwt.vercel.app
Deployment aliased as nrn-v2-mst-aptd-at-lcz-sty-c1-storybook-j.vercel.app

@github-actions
Copy link

✅  E2E tests SUCCESS for commit d9404ee previously deployed at https://nrn-v2-mst-aptd-at-lcz-sty-c1-qhxbt0kwt.vercel.app

@Vadorequest Vadorequest marked this pull request as ready for review January 17, 2021 10:09
@Vadorequest Vadorequest mentioned this pull request Jan 17, 2021
Closed
@github-actions
Copy link

✅  Deployment SUCCESS
Commit 36b8769 successfully deployed to https://nrn-v2-mst-aptd-at-lcz-sty-c1-1matoblzg.vercel.app
Deployment aliased as nrn-v2-mst-aptd-at-lcz-sty-c1-storybook-j.vercel.app

@github-actions
Copy link

✅  Deployment SUCCESS
Commit 36b8769 successfully deployed Storybook static site to https://nrn-v2-mst-aptd-at-lcz-sty-storybook-635ilxu9f.vercel.app
Deployment aliased as nrn-v2-mst-aptd-at-lcz-sty-storybook

@github-actions
Copy link

✅  E2E tests SUCCESS for commit 36b8769 previously deployed at https://nrn-v2-mst-aptd-at-lcz-sty-c1-1matoblzg.vercel.app

@github-actions
Copy link

✅  E2E tests SUCCESS for commit 36b8769 previously deployed Storybook static site at https://nrn-v2-mst-aptd-at-lcz-sty-storybook-635ilxu9f.vercel.app

@Vadorequest Vadorequest merged commit e5aba8e into v2-mst-aptd-at-lcz-sty Jan 17, 2021
@Vadorequest Vadorequest deleted the storybook-jest branch January 17, 2021 10:55
Vadorequest added a commit that referenced this pull request Jan 17, 2021
@Vadorequest
Add "Jest" addon for Storybook (#262)
9f46048
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Vadorequest