Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bugfix 157 e2e failing #159

Merged
merged 4 commits into from
Sep 6, 2020
Merged

Bugfix 157 e2e failing #159

merged 4 commits into from
Sep 6, 2020

Conversation

Vadorequest
Copy link
Member

@Vadorequest Vadorequest commented Sep 6, 2020 •
edited
Loading

Closes #157

Catch Cypress uncaught:exception makes tests pass on GHA, increasing timeout makes tests pass locally

@Vadorequest
Add e2e:run:spec:common command to show an example on how to run a gr…
644901f 
…oup of E2E specs using glob pattern
@Vadorequest
Increase timeout before crashing fixes the issue locally (10s > 15s) …
9b130a0 
…but it's unknown why tests need that much time, they shouldn't
@Vadorequest Vadorequest self-assigned this Sep 6, 2020
@Vadorequest Vadorequest linked an issue Sep 6, 2020 that may be closed by this pull request
E2E tests are failing in "Common > Nav section" #157
Closed
@github-actions
Copy link

github-actions bot commented Sep 6, 2020

✅  Deployment SUCCESS
Commit 9b130a0 successfully deployed to https://nrn-v2-mst-aptd-at-lcz-sty-c1-h0fo7u6kv.vercel.app
Deployment aliased as https://nrn-v2-mst-aptd-at-lcz-sty-c1-bugfix-157.vercel.app

@github-actions
Copy link

github-actions bot commented Sep 6, 2020

❌  E2E tests FAILED
Download artifacts (screenshots + videos) from checks section

@Vadorequest Vadorequest mentioned this pull request Sep 6, 2020
Closed
@github-actions
Copy link

github-actions bot commented Sep 6, 2020

✅  Deployment SUCCESS
Commit cf8c64d successfully deployed to https://nrn-v2-mst-aptd-at-lcz-sty-c1-h0fo7u6kv.vercel.app
Deployment aliased as https://nrn-v2-mst-aptd-at-lcz-sty-c1-bugfix-157.vercel.app

@github-actions
Copy link

github-actions bot commented Sep 6, 2020

❌  E2E tests FAILED
Download artifacts (screenshots + videos) from checks section

@github-actions
Copy link

github-actions bot commented Sep 6, 2020

✅  Deployment SUCCESS
Commit fce8df6 successfully deployed to https://nrn-v2-mst-aptd-at-lcz-sty-c1-h0fo7u6kv.vercel.app
Deployment aliased as https://nrn-v2-mst-aptd-at-lcz-sty-c1-bugfix-157.vercel.app

@github-actions
Copy link

github-actions bot commented Sep 6, 2020

✅  E2E tests SUCCESS

@Vadorequest Vadorequest merged commit c1ea458 into v2-mst-aptd-at-lcz-sty Sep 6, 2020
@Vadorequest Vadorequest deleted the bugfix-157-e2e-failing branch September 6, 2020 09:31
Vadorequest added a commit that referenced this pull request Sep 6, 2020
@Vadorequest
Bugfix 157 e2e failing (#159)
9e99898 
Catch Cypress `uncaught:exception` makes tests pass on GHA, increasing timeout makes tests pass locally
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Vadorequest Vadorequest

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

E2E tests are failing in "Common > Nav section"
1 participant
@Vadorequest