Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GDPR - Add cookie consent UI #140

Merged
merged 16 commits into from
Jul 27, 2020
Merged

Conversation

Vadorequest
Copy link
Member

@Vadorequest Vadorequest commented Jul 26, 2020

Demo: https://nrn-v2-mst-aptd-at-lcz-sty-c1-cookies-con.vercel.app

Allow end-users to consent (or not) to cookies.

Simple implementation based on the open-source tool "cookieconsent", only handle agree/deny/dismiss choices.

Creates a cookie to store the user's choice on the device.
When users don't consent, all analytics is disabled (Amplitude).
When users consent, their choice is stored on Amplitude, and their behavior is tracked.

Stores events for people who deny/allow, so that we can have some stats about how many agree and don't, also stores metadata associated with the consent (time, message displayed to the user)

The Amplitude cookie is not destroyed when user denies though, or it wouldn't be possible to switch on/off easily during navigation without a full page refresh, this isn't perfect according to GDPR, but I don't see how to do it better without completely disabling Amplitude when user has denied. Which would likely lead to other issues.

@Vadorequest Vadorequest changed the title Add cookie consent UI GDPR - Add cookie consent UI Jul 26, 2020
@github-actions
Copy link

✅  Deployment SUCCESS
Commit 6f0cb7a successfully deployed to https://nrn-v2-mst-aptd-at-lcz-sty-c1-lgekq3m8v.vercel.app
Deployment aliased as https://nrn-v2-mst-aptd-at-lcz-sty-c1-cookies-con.vercel.app

@github-actions
Copy link

✅  E2E tests SUCCESS

@github-actions
Copy link

✅  Deployment SUCCESS
Commit f72c7c0 successfully deployed to https://nrn-v2-mst-aptd-at-lcz-sty-c1-qv0mgvfbv.vercel.app
Deployment aliased as https://nrn-v2-mst-aptd-at-lcz-sty-c1-cookies-con.vercel.app

@github-actions
Copy link

✅  E2E tests SUCCESS

@github-actions
Copy link

✅  Deployment SUCCESS
Commit 0f4ba05 successfully deployed to https://nrn-v2-mst-aptd-at-lcz-sty-c1-8o9dlp5jx.vercel.app
Deployment aliased as https://nrn-v2-mst-aptd-at-lcz-sty-c1-cookies-con.vercel.app

@github-actions
Copy link

✅  E2E tests SUCCESS

@github-actions
Copy link

✅  Deployment SUCCESS
Commit 33ffaaf successfully deployed to https://nrn-v2-mst-aptd-at-lcz-sty-c1-5gpsiv7fr.vercel.app
Deployment aliased as https://nrn-v2-mst-aptd-at-lcz-sty-c1-cookies-con.vercel.app

@github-actions
Copy link

✅  E2E tests SUCCESS

@github-actions
Copy link

✅  Deployment SUCCESS
Commit 7a77ea6 successfully deployed to https://nrn-v2-mst-aptd-at-lcz-sty-c1-pttvy7yno.vercel.app
Deployment aliased as https://nrn-v2-mst-aptd-at-lcz-sty-c1-cookies-con.vercel.app

@github-actions
Copy link

✅  E2E tests SUCCESS

…hook + disable Amplitude tracking when the user is opted-out + configured cookieConsent lib
…vailable on the browser, so we use DisplayOnBrowserMount component to defer the mount for the browser only (avoid mismatch browser vs server)
@github-actions
Copy link

✅  Deployment SUCCESS
Commit 37e3f5c successfully deployed to https://nrn-v2-mst-aptd-at-lcz-sty-c1-s2d42sqy8.vercel.app
Deployment aliased as https://nrn-v2-mst-aptd-at-lcz-sty-c1-cookies-con.vercel.app

@github-actions
Copy link

✅  E2E tests SUCCESS

@github-actions
Copy link

✅  Deployment SUCCESS
Commit b7d1ea4 successfully deployed to https://nrn-v2-mst-aptd-at-lcz-sty-c1-74ds3ll91.vercel.app
Deployment aliased as https://nrn-v2-mst-aptd-at-lcz-sty-c1-cookies-con.vercel.app

@github-actions
Copy link

❌  E2E tests FAILED
Download artifacts (screenshots + videos) from checks section

…e transitions (needs full page refresh to show/hide properly)
@github-actions
Copy link

✅  Deployment SUCCESS
Commit 3371443 successfully deployed to https://nrn-v2-mst-aptd-at-lcz-sty-c1-ossiqe0ph.vercel.app
Deployment aliased as https://nrn-v2-mst-aptd-at-lcz-sty-c1-cookies-con.vercel.app

@github-actions
Copy link

✅  E2E tests SUCCESS

@github-actions
Copy link

✅  Deployment SUCCESS
Commit 356bc3a successfully deployed to https://nrn-v2-mst-aptd-at-lcz-sty-c1-k6ztan7h4.vercel.app
Deployment aliased as https://nrn-v2-mst-aptd-at-lcz-sty-c1-cookies-con.vercel.app

@github-actions
Copy link

✅  E2E tests SUCCESS

@Vadorequest Vadorequest marked this pull request as ready for review July 27, 2020 21:43
@github-actions
Copy link

✅  Deployment SUCCESS
Commit eaa4bd2 successfully deployed to https://nrn-v2-mst-aptd-at-lcz-sty-c1-mrwhkicgk.vercel.app
Deployment aliased as https://nrn-v2-mst-aptd-at-lcz-sty-c1-cookies-con.vercel.app

@github-actions
Copy link

✅  E2E tests SUCCESS

@github-actions
Copy link

✅  Deployment SUCCESS
Commit 9968b12 successfully deployed to https://nrn-v2-mst-aptd-at-lcz-sty-c1-ivso5zh4q.vercel.app
Deployment aliased as https://nrn-v2-mst-aptd-at-lcz-sty-c1-cookies-con.vercel.app

@github-actions
Copy link

✅  E2E tests SUCCESS

@Vadorequest Vadorequest merged commit d39a4d6 into v2-mst-aptd-at-lcz-sty Jul 27, 2020
@Vadorequest Vadorequest deleted the cookies-consent branch July 27, 2020 22:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant