Fix - GHA are not triggered in case of merge

[Demmonius]

Fix #103 not triggering on PR merge.

[Vadorequest]

[GitHub Actions]
Deployment FAILED
Commit e6e0caf failed to deploy to
click to see logs

[Vadorequest]

[GitHub Actions]
Deployment FAILED
Commit e6e0caf failed to deploy to
click to see logs

[Vadorequest]

[GitHub Actions]
Deployment FAILED
Commit 9cb1b33 failed to deploy to
click to see logs

[Vadorequest]

[GitHub Actions]
Deployment FAILED
Commit eb0ad8e failed to deploy to
click to see logs

[Vadorequest]

[GitHub Actions]
Deployment SUCCESS
Commit faadf96 successfully deployed to https://nrn-v2-mst-aptd-at-lcz-sty-c1-93kav5g8k.vercel.app
Deployment aliased as https://nrn-v2-mst-aptd-at-lcz-sty-c1-lighthouse.vercel.app

[Vadorequest]

[GitHub Actions]
E2E tests SUCCESS

[Vadorequest]

[GitHub Actions]
Deployment SUCCESS
Commit ab928ce successfully deployed to https://nrn-v2-mst-aptd-at-lcz-sty-c1-htzo9p2pz.vercel.app
Deployment aliased as https://nrn-v2-mst-aptd-at-lcz-sty-c1-lighthouse.vercel.app

[Vadorequest]

[GitHub Actions]
E2E tests SUCCESS

[Vadorequest]

[GitHub Actions]
Deployment SUCCESS
Commit 9ebe44b successfully deployed to https://nrn-v2-mst-aptd-at-lcz-sty-c1-fknxmuyqg.vercel.app
Deployment aliased as https://nrn-v2-mst-aptd-at-lcz-sty-c1-lighthouse.vercel.app

[Vadorequest]

[GitHub Actions]
Deployment SUCCESS
Commit 85c5a36 successfully deployed to https://nrn-v2-mst-aptd-at-lcz-sty-c1-ebkdq24sx.vercel.app
Deployment aliased as https://nrn-v2-mst-aptd-at-lcz-sty-c1-lighthouse.vercel.app

[Vadorequest]

[GitHub Actions]
E2E tests FAILED
Download artifacts (screenshots + videos) from checks section

[Vadorequest]

[GitHub Actions]
Deployment SUCCESS
Commit b28a590 successfully deployed to https://nrn-v2-mst-aptd-at-lcz-sty-c1-20cnunsli.vercel.app
Deployment aliased as https://nrn-v2-mst-aptd-at-lcz-sty-c1-lighthouse.vercel.app

[Vadorequest]

[GitHub Actions]
E2E tests FAILED
Download artifacts (screenshots + videos) from checks section

[Vadorequest]

[GitHub Actions]
Deployment SUCCESS
Commit 7795376 successfully deployed to https://nrn-v2-mst-aptd-at-lcz-sty-c1-pz6z3xu9a.vercel.app
Deployment aliased as https://nrn-v2-mst-aptd-at-lcz-sty-c1-lighthouse.vercel.app

[Vadorequest]

[GitHub Actions]
E2E tests SUCCESS

[Vadorequest]

[GitHub Actions]
Lighthouse report

{"code":"SUCCESS","data":[{"url":"https://nrn-v2-mst-aptd-at-lcz-sty-c1-pz6z3xu9a.vercel.app","localReport":"/tmp/lighthouse-artifacts/lighthouse-report-1591983670371.html","scores":{"accessibility":98,"bestPractices":100,"performance":65,"progressiveWebApp":56,"seo":92}}]}

https://nrn-v2-mst-aptd-at-lcz-sty-c1-pz6z3xu9a.vercel.app

[Vadorequest]

[GitHub Actions]
E2E tests SUCCESS

[Vadorequest]

[GitHub Actions]
Deployment SUCCESS
Commit 467c1ea successfully deployed to https://nrn-v2-mst-aptd-at-lcz-sty-c1-lbpt1b58r.vercel.app
Deployment aliased as https://nrn-v2-mst-aptd-at-lcz-sty-c1-lighthouse.vercel.app

[Vadorequest]

[GitHub Actions]
Lighthouse report

https://nrn-v2-mst-aptd-at-lcz-sty-c1-lbpt1b58r.vercel.app

[Vadorequest]

[GitHub Actions]
E2E tests SUCCESS

[Vadorequest]

[GitHub Actions] - Lighthouse report for https://nrn-v2-mst-aptd-at-lcz-sty-c1-f9z92i60r.vercel.app

[Vadorequest]

[GitHub Actions]
E2E tests SUCCESS

[Vadorequest]

@Demmonius After reviewing, here is a summary of feedback:

• Currently, colors are hardcoded (e.g: green) in LH reports, we need to find a better alternative. This isn't critical and could be solved later. I've opened Question - How to resolve the colors easily when manually writing comments? foo-software/lighthouse-check-action#27 to track it down.
• Most of the LH complexity we're running into is because https://github.com/foo-software/lighthouse-check-action doesn't provide a prCommentUrl option, which is available in https://github.com/foo-software/lighthouse-check#options though. I believe it could be simplified quite a lot if such option was available in lighthouse-check-action. (we wouldn't need to write the LH comment manually) - This is why you said we had to use pull_request event for LightHouse to work.
• Code is replicated 3 times regarding Finding Pull Request ID action. This isn't good and we need to find a way to run it only once, I don't get why we need it 3 times. We should be able to run it once at the beginning, and forward it down to the actions that need it. This should be done in this PR.
• Debugging is very slow and the use of https://github.com/nektos/act seems required to make our GHA setup more maintainable. But this is likely to be an important task, and must be done in a separate PR.

[Vadorequest]

[GitHub Actions]
Deployment SUCCESS
Commit 2e6075c successfully deployed to https://nrn-v2-mst-aptd-at-lcz-sty-c1-o81l1559n.vercel.app
Deployment aliased as https://nrn-v2-mst-aptd-at-lcz-sty-c1-lighthouse.vercel.app

[Vadorequest]

[GitHub Actions] - Lighthouse report for https://nrn-v2-mst-aptd-at-lcz-sty-c1-cq2ixz1d8.vercel.app

[Demmonius]

@Vadorequest As I told you, we have to repeat this action. Each "job" is run in a different environment and so we can't do a setenv or use the ouput in another job. Although I don't like it, I can't do otherwise at the moment.

I'll work on ACT in another PR but for me, the work is done here :)

[Demmonius]

What would you like to do about the colors?

[Vadorequest]

[GitHub Actions]
E2E tests FAILED
Download artifacts (screenshots + videos) from checks section

[Vadorequest]

[GitHub Actions]
Deployment SUCCESS
Commit 3fc2226 successfully deployed to https://nrn-v2-mst-aptd-at-lcz-sty-c1-cq2ixz1d8.vercel.app
Deployment aliased as https://nrn-v2-mst-aptd-at-lcz-sty-c1-lighthouse.vercel.app

[Vadorequest]

[GitHub Actions] - Lighthouse report for https://nrn-v2-mst-aptd-at-lcz-sty-c1-cq2ixz1d8.vercel.app

[Vadorequest]

[GitHub Actions]
E2E tests SUCCESS

[Vadorequest]

Alright, so:

• Currently, colors are hardcoded (e.g: green) in LH reports, we need to find a better alternative. This isn't critical and could be solved later. I've opened Question - How to resolve the colors easily when manually writing comments? foo-software/lighthouse-check-action#27 to track it down.
• Most of the LH complexity we're running into is because https://github.com/foo-software/lighthouse-check-action doesn't provide a prCommentUrl option, which is available in https://github.com/foo-software/lighthouse-check#options though. I believe it could be simplified quite a lot if such option was available in lighthouse-check-action. (we wouldn't need to write the LH comment manually) - This is why you said we had to use pull_request event for LightHouse to work.

Let's wait and see if https://github.com/foo-software/lighthouse-check-action add the ability to specify a prCommentUrl, which would simplify this quite a lot.

• Code is replicated 3 times regarding Finding Pull Request ID action. This isn't good and we need to find a way to run it only once, I don't get why we need it 3 times. We should be able to run it once at the beginning, and forward it down to the actions that need it. This should be done in this PR.

Apparently, there is not better alternative, so let's keep it that way.

• Debugging is very slow and the use of https://github.com/nektos/act seems required to make our GHA setup more maintainable. But this is likely to be an important task, and must be done in a separate PR.

To be done in a separated PR.

Looks like we're done here. I'll review and merge.

[Vadorequest]

[GitHub Actions]
Deployment SUCCESS
Commit e421099 successfully deployed to https://nrn-v2-mst-aptd-at-lcz-sty-c1-jvplgf4mh.vercel.app
Deployment aliased as https://nrn-v2-mst-aptd-at-lcz-sty-c1-lighthouse.vercel.app

[Vadorequest]

[GitHub Actions] - Lighthouse report for https://nrn-v2-mst-aptd-at-lcz-sty-c1-jvplgf4mh.vercel.app

[Vadorequest]

[GitHub Actions]
E2E tests SUCCESS

[Vadorequest]

[GitHub Actions]
Deployment SUCCESS
Commit 76a91ff successfully deployed to https://nrn-v2-mst-aptd-at-lcz-sty-c1-2z9fourfl.vercel.app
Deployment aliased as https://nrn-v2-mst-aptd-at-lcz-sty-c1-lighthouse.vercel.app

[Vadorequest]

[GitHub Actions] - Lighthouse report for https://nrn-v2-mst-aptd-at-lcz-sty-c1-2z9fourfl.vercel.app

[Vadorequest]

[GitHub Actions]
E2E tests SUCCESS