Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adds retry mechanism on network failures #97

Merged
merged 1 commit into from
May 26, 2023

Conversation

dlively1
Copy link
Contributor

👋 Thanks for making this action. We have been using it quite a bit in a high throughput environment.

We have ran into some issues with the Vercel API so we added a simple retry mechanism to avoid failing our CI checks. We've been running it for a few months and it helped stabilize our pipeline.

I tried to find the most compatible retry library to be as "drop-in" as possible.

Copy link
Member

@Vadorequest Vadorequest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR, it looks okay, i'd just change the version of the fetch library.

package.json Show resolved Hide resolved
@Vadorequest Vadorequest mentioned this pull request May 26, 2023
@Vadorequest Vadorequest self-assigned this May 26, 2023
@Vadorequest Vadorequest changed the base branch from main to retry-network May 26, 2023 21:49
@Vadorequest Vadorequest merged commit 0100f54 into UnlyEd:retry-network May 26, 2023
@Vadorequest
Copy link
Member

PR migrated to #98

Vadorequest added a commit that referenced this pull request May 26, 2023
Co-authored-by: Dan Lively <daniel.lively12@gmail.com>
@Vadorequest
Copy link
Member

#98 merged

Thank you @dlively1 !

@namoscato namoscato mentioned this pull request May 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants