Skip to content

Commit

Permalink
chore: drop release plan template view permissions (#9195)
Browse files Browse the repository at this point in the history
https://linear.app/unleash/issue/2-3225/drop-the-release-template-view-permissions

Drops the release plan template view permissions in favor of an "open by
default" approach.

Should merge the Enterprise PR first.
  • Loading branch information
nunogois authored Feb 3, 2025
1 parent f9e0c27 commit 138410e
Show file tree
Hide file tree
Showing 2 changed files with 21 additions and 5 deletions.
5 changes: 0 additions & 5 deletions src/lib/types/permissions.ts
Original file line number Diff line number Diff line change
Expand Up @@ -80,9 +80,6 @@ export const PROJECT_DEFAULT_STRATEGY_WRITE = 'PROJECT_DEFAULT_STRATEGY_WRITE';
export const PROJECT_CHANGE_REQUEST_WRITE = 'PROJECT_CHANGE_REQUEST_WRITE';
export const PROJECT_SETTINGS_WRITE = 'PROJECT_SETTINGS_WRITE';

export const RELEASE_PLAN_TEMPLATE_VIEW_OVERVIEW =
'RELEASE_PLAN_TEMPLATE_VIEW_OVERVIEW';
export const RELEASE_PLAN_TEMPLATE_VIEW = 'RELEASE_PLAN_TEMPLATE_VIEW';
export const RELEASE_PLAN_TEMPLATE_CREATE = 'RELEASE_PLAN_TEMPLATE_CREATE';
export const RELEASE_PLAN_TEMPLATE_UPDATE = 'RELEASE_PLAN_TEMPLATE_UPDATE';
export const RELEASE_PLAN_TEMPLATE_DELETE = 'RELEASE_PLAN_TEMPLATE_DELETE';
Expand Down Expand Up @@ -140,8 +137,6 @@ export const ROOT_PERMISSION_CATEGORIES = [
{
label: 'Release plan templates',
permissions: [
RELEASE_PLAN_TEMPLATE_VIEW_OVERVIEW,
RELEASE_PLAN_TEMPLATE_VIEW,
RELEASE_PLAN_TEMPLATE_CREATE,
RELEASE_PLAN_TEMPLATE_DELETE,
RELEASE_PLAN_TEMPLATE_UPDATE,
Expand Down
21 changes: 21 additions & 0 deletions src/migrations/20250203145735-drop-rp-view-permissions.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,21 @@
exports.up = (db, cb) => {
db.runSql(`
DELETE
FROM permissions
WHERE permission IN
('RELEASE_PLAN_TEMPLATE_VIEW_OVERVIEW', 'RELEASE_PLAN_TEMPLATE_VIEW');
`, cb);

};

exports.down = (db, cb) => {
db.runSql(`
INSERT INTO permissions(permission, display_name, type) VALUES
('RELEASE_PLAN_TEMPLATE_VIEW_OVERVIEW', 'View overview of release plan templates', 'root'),
('RELEASE_PLAN_TEMPLATE_VIEW', 'View details of specific release plan template', 'root');
INSERT INTO role_permission(role_id, permission, created_by_user_id)
SELECT id, 'RELEASE_PLAN_TEMPLATE_VIEW_OVERVIEW', '-1337' FROM roles WHERE name IN ('Viewer', 'Editor') AND type = 'root';
INSERT INTO role_permission(role_id, permission, created_by_user_id)
SELECT id, 'RELEASE_PLAN_TEMPLATE_VIEW', '-1337' FROM roles WHERE name = 'Editor' AND type = 'root';
`, cb);
};

0 comments on commit 138410e

Please sign in to comment.