fix: New feedback is not shown in results

cypress/integration/interimFeedback.spec.js

@@ -341,7 +341,7 @@ describe('Students', () => {
     // New tabs are rendered when feedback was given
     cy.get('[data-cy="interim-feedback-target-edit-feedback-tab"]').should('exist')
     cy.get('[data-cy="interim-feedback-target-results-tab"]').should('exist').click()
-    cy.get('[data-cy="notEnoughFeedbacks"]').should('exist')
+    cy.contains('Multiple choice questions')
 
     cy.url().should('include', '/results')
 

cypress/integration/userfeedbacks.spec.js

@@ -38,6 +38,23 @@ describe('User feedbacks view', () => {
       .should('not.exist')
   })
 
+  it('Feedback is visible immediately after being given', () => {
+    cy.loginAs(student)
+    cy.get('@fbtId').then(id => cy.visit(`/targets/${id}`))
+    cy.get('input[value=5]').each($el => {
+      cy.get($el).click()
+    })
+    cy.getUniversityQuestions().then(questions => {
+      const openQuestion = questions.find(q => q.type === 'OPEN')
+      cy.get(`textarea[id=${openQuestion.id}-label]`).type('Other comments and such')
+    })
+    cy.get('[data-cy=feedback-view-give-feedback]').click()
+
+    cy.get('[data-cy="feedback-target-results-tab"]')
+
+    cy.contains('Multiple choice questions')
+  })
+
   it('Teacher can censor a feedback', () => {
     // student gives feedback
     cy.loginAs(student)

src/client/pages/FeedbackTarget/tabs/FeedbackView/utils.js

@@ -152,14 +152,11 @@ export const useSaveValues = () => {
       return data
     },
     {
-      onSuccess: feedback => {
-        queryClient.setQueryData(['feedbackTarget', String(feedbackTarget.id)], prev => ({
-          ...prev,
-          feedback,
-        }))
-
+      onSuccess: () => {
         // Invalidate the waiting feedback count for the student
         queryClient.invalidateQueries('myFeedbacksWaitingFeedbackCount')
+        // Invalidate the feedbackTarget data
+        queryClient.invalidateQueries(['feedbackTarget', String(feedbackTarget.id)])
       },
     }
   )

src/server/util/logger.ts

@@ -18,7 +18,17 @@ if (process.env.NODE_ENV !== 'test') {
 if (!inProduction) {
   const devFormat = printf(
     // eslint-disable-next-line @typescript-eslint/no-shadow
-    ({ level, message, timestamp, ...rest }) => `${timestamp} ${level}: ${message} ${JSON.stringify(rest)}`
+    ({ level, message, timestamp, ...rest }) => {
+      let restMsg = ''
+      try {
+        restMsg = JSON.stringify(rest)
+      } catch (e) {
+        // eslint-disable-next-line no-console
+        console.error('Failed to stringify log message', rest)
+      }
+      const msg = `${timestamp} ${level}: ${message} ${restMsg}`
+      return msg
+    }
   )
 
   transports.push(