Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use compare_digest when search by client_secret #46

Merged
merged 1 commit into from
Oct 31, 2023

Conversation

melanger
Copy link
Contributor

No description provided.

@melanger melanger requested a review from peppelinux October 30, 2023 21:39
@melanger melanger self-assigned this Oct 30, 2023
@peppelinux
Copy link
Member

consider it merged @melanger

I just need to ask you to change the version up to 3.1.0, since it is not a bugfix but an additional security feature that matters

@melanger
Copy link
Contributor Author

consider it merged @melanger

I just need to ask you to change the version up to 3.1.0, since it is not a bugfix but an additional security feature that matters

@peppelinux It's a security fix, it does not add any new behavior. https://semver.org/#spec-item-6

@peppelinux
Copy link
Member

@melanger ok, just change the version in this PR so that the new release will be coerent with the version of semantic bot

@melanger
Copy link
Contributor Author

@melanger ok, just change the version in this PR so that the new release will be coerent with the version of semantic bot

semantic release will update the version number automatically :)

@melanger melanger merged commit c3c3560 into main Oct 31, 2023
12 checks passed
@melanger melanger deleted the melanger-patch-1 branch October 31, 2023 11:51
@github-actions
Copy link

🎉 This PR is included in version 3.0.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants