Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sub_type pairwise cannot be selected #21

Closed
vladimir-mencl-eresearch opened this issue Nov 3, 2022 · 2 comments · Fixed by #25
Closed

Sub_type pairwise cannot be selected #21

vladimir-mencl-eresearch opened this issue Nov 3, 2022 · 2 comments · Fixed by #25
Assignees
@vladimir-mencl-eresearch
Labels
enhancement New feature or request help wanted Extra attention is needed released

Comments

@vladimir-mencl-eresearch
Copy link
Collaborator

Hi,

This is partly a follow-up to #20.

I see the OidcOpFrontend module is meant to support pairwise sub_type, but this cannot really be selected.

In oidcop/session/manager.py, create_session has sub_type defaulting to public, but when OidcOpFrontend calls create_session, it does not pass a value for sub_type, so public is always used as the default.

I'd think that if a client has include subject_type in its registration, the value passed under subject_type should be used for the sub_type argument to create_session - that would solve this issue.

Thanks a lot in advance for considering it.

Cheers,
Vlad
This was referenced Nov 3, 2022
Open
Closed
@peppelinux
Copy link
Member

Ok, you mean here
https://github.com/UniversitaDellaCalabria/SATOSA-oidcop/blob/main/satosa_oidcop/idpy_oidcop.py#L637

I'm ok with this proposal, if we don't have any cons we can proceed with a PR if you agree @vladimir-mencl-eresearch

@peppelinux peppelinux added enhancement New feature or request help wanted Extra attention is needed labels Nov 9, 2022
Merged
github-actions bot pushed a commit that referenced this issue Dec 14, 2022
@semantic-release-bot
chore(release): 1.1.0 [skip ci]
5e366da 
# [1.1.0](v1.0.1...v1.1.0) (2022-12-14)

### Features

* pass subject_type from client config to create_session as sub_type ([83b3e81](83b3e81)), closes [#21](#21)
@github-actions
Copy link

🎉 This issue has been resolved in version 1.1.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vladimir-mencl-eresearch vladimir-mencl-eresearch

Labels
enhancement New feature or request help wanted Extra attention is needed released
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: pass subject_type from client config to create_session as sub_type REANNZ/SATOSA-oidcop
2 participants
@vladimir-mencl-eresearch @peppelinux