Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update game data in the correct location #171

Merged
merged 1 commit into from
Dec 20, 2024

Conversation

karashiiro
Copy link
Member

@karashiiro karashiiro commented Dec 20, 2024

Summary by CodeRabbit

  • Bug Fixes

    • Removed multiple JSON files that contained mappings for classes, items, and categories across various languages, which may have caused issues in item management and display.
  • Chores

    • Deleted obsolete JSON files from the application to streamline data management and reduce clutter.

Copy link

coderabbitai bot commented Dec 20, 2024

Caution

Review failed

The pull request is closed.

Walkthrough

The pull request involves the deletion of multiple JSON files across different language directories (Chinese, German, English, French, and Japanese) within the MogboardExporter tool. These files contained structured data for game-related information, including character classes, item categories, and item mappings. The removed files were located in subdirectories for different languages and covered various aspects of game data such as class identifiers, item kinds, and item classifications.

Changes

File Path Change Summary
../datagame/*/cjc.json Deleted JSON files mapping numerical IDs to character class names across Chinese, German, English, French, and Japanese versions
../datagame/*/isc.json Removed JSON files containing structured item data with categories and order information
../datagame/*/itemKinds.json Deleted JSON objects defining item categories in multiple languages
../datagame/*/iuc.json Removed JSON files mapping item IDs to their corresponding names

Poem

🐰 Farewell, JSON files so neat,
Rabbit hops through empty data sheet
Classes, items, all erased
With a whisker twitch, they're replaced
Coding magic, swift and light! 🔍


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between a4f7496 and 7ff0c24.

📒 Files selected for processing (20)
  • tools/MogboardExporter/MogboardExporter.CafeMaker/......datagame/chs/cjc.json (0 hunks)
  • tools/MogboardExporter/MogboardExporter.CafeMaker/......datagame/chs/isc.json (0 hunks)
  • tools/MogboardExporter/MogboardExporter.CafeMaker/......datagame/chs/itemKinds.json (0 hunks)
  • tools/MogboardExporter/MogboardExporter.CafeMaker/......datagame/chs/iuc.json (0 hunks)
  • tools/MogboardExporter/MogboardExporter/......datagame/de/cjc.json (0 hunks)
  • tools/MogboardExporter/MogboardExporter/......datagame/de/isc.json (0 hunks)
  • tools/MogboardExporter/MogboardExporter/......datagame/de/itemKinds.json (0 hunks)
  • tools/MogboardExporter/MogboardExporter/......datagame/de/iuc.json (0 hunks)
  • tools/MogboardExporter/MogboardExporter/......datagame/en/cjc.json (0 hunks)
  • tools/MogboardExporter/MogboardExporter/......datagame/en/isc.json (0 hunks)
  • tools/MogboardExporter/MogboardExporter/......datagame/en/itemKinds.json (0 hunks)
  • tools/MogboardExporter/MogboardExporter/......datagame/en/iuc.json (0 hunks)
  • tools/MogboardExporter/MogboardExporter/......datagame/fr/cjc.json (0 hunks)
  • tools/MogboardExporter/MogboardExporter/......datagame/fr/isc.json (0 hunks)
  • tools/MogboardExporter/MogboardExporter/......datagame/fr/itemKinds.json (0 hunks)
  • tools/MogboardExporter/MogboardExporter/......datagame/fr/iuc.json (0 hunks)
  • tools/MogboardExporter/MogboardExporter/......datagame/ja/cjc.json (0 hunks)
  • tools/MogboardExporter/MogboardExporter/......datagame/ja/isc.json (0 hunks)
  • tools/MogboardExporter/MogboardExporter/......datagame/ja/itemKinds.json (0 hunks)
  • tools/MogboardExporter/MogboardExporter/......datagame/ja/iuc.json (0 hunks)

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@karashiiro karashiiro merged commit 634a683 into Universalis-FFXIV:main Dec 20, 2024
0 of 2 checks passed
@karashiiro karashiiro deleted the fix/7.15-2 branch December 20, 2024 02:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant