Remove all build warnings #1233
Conversation
Fail the controller function if writing to a command interface fails. For the GPIO controller we ignore the return value, as we are checking the result anyway.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1233 +/- ##
========================================
+ Coverage 3.59% 3.77% +0.18%
========================================
Files 13 395 +382
Lines 947 43513 +42566
Branches 152 6407 +6255
========================================
+ Hits 34 1643 +1609
- Misses 843 41727 +40884
- Partials 70 143 +73
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
Note: For the time being I expect main builds to fail, due to PickNikRobotics/generate_parameter_library@01e9dce just being released and only available in testing. The remaining warning is due to a missing release of control_toolbox, see ros-controls/control_toolbox@74510fd |
urfeex
force-pushed
the
no_build_warnings
branch
from
9e8f3cf to
2158dab
Compare
|
This now builds successfully on jazzy testing. I don't quite know why the tests are failing on rolling currently, they don't do that locally, but that test has to be fixed separately. Hence, I'll mark this ready for review. |
| @@ -407,16 +408,17 @@ bool GPIOController::setAnalogOutput(ur_msgs::srv::SetAnalogOutput::Request::Sha | |||
| return false; | |||
| } | |||
|
|
|||
| if (req->data.pin < 0 || req->data.pin > 1) { | |||
| if (!(req->data.pin == 0 || req->data.pin == 1)) { | |||
There was a problem hiding this comment.
No, but that't the pin index. There are only pins 0 and 1. It's not the analog value.
|
With fixing the test pipelines are as expected. I'll remove the test fix from this PR again, merge it and make a separate PR about fixing the test. |
urfeex
force-pushed
the
no_build_warnings
branch
from
4d53104 to
2158dab
Compare
This PR aims at reducing the build warnings to 0.