Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed rock sliding bug #532

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

dkphill
Copy link

@dkphill dkphill commented Apr 22, 2023

This PR addresses issue #499.

I noticed that, while the player is stuck on the rock, adjusting the minimum slope on the characterController to be around 90 allowed the player to move again. Therefore, I decided to implement a failsafe in Protagonist.cs that detects when the player is colliding with a rock, and if so, sets the minimum slope value to 90. When they leave the rock collider, the minimum slope is set back to its original value. Although this does not necessarily address the root of this bug, I found that it made for a good temporary fix.

After implementing the changes, this is how the character and rocks behaved on my laptop: https://imgur.com/a/l1vArnX

@avdheshb6
Copy link

Complete the review section

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants