BUG: DropDownList gives null exc if using TextMeshProUGUI rather than old Text #424
Assignees
Comments
|
Closing as this is a duplicate of #410, the resolution is in the 2.3 branch and is getting released asap for the 2.3 release |
|
Scratch that, I'm an idiot. Thanks for the report @WazWaz , will ensure to check all uses for old text vs textmesh pro and resolve |
SimonDarksideJ
pushed a commit
that referenced
this issue
Feb 4, 2023
|
OK, need some feedback @WazWaz if you can respond, as digging into this is creating more problems than it is solving. Would it be better to have the existing components update to use TextMeshPro for 2022, or introduce NEW TextMesh Pro versions (like Unity has) that can be used. Essentially, there is NO forward path from Text to TextMeshPro, and even though I introduced fixes, this breaks backwards compatibility. |
|
I probably ran into the same issues you did when I tried to work around. I ended up just using the Unity TMP_Dropdown. Now I don't remember why I wasn't using Unity's Dropdown before porting to use TMP. My code ended up cleaner when ported to use TMP_Dropdown too, so maybe it's time to deprecate DropDownList, which does nasty stuff like the hardcoded 0,4 offset and other messing with RectTransforms. If you want to keep it, yes, I'd suggest a TMP_DropDownList, ideally one that respects the user's MainButton and template better. Sorry I can't suggest more, now I've ported away. |
SimonDarksideJ
added a commit
that referenced
this issue
Feb 7, 2023
* Package upver for Development * Added OnHighlightChanged and OnPressChanged events Added getters and setters for Highlighted and Pressed * Patch fix for UILineRenderer * Update package preview release * Resolves issue where the lower range value would become stuck when moved to the max value position Resolves: https://bitbucket.org/UnityUIExtensions/unity-ui-extensions/issues/381/cant-move-range-slider-if-low-is-moved-to * Updated Infinite scroll to work with content of different sizes * Clean-up and reset pivots on scene start * Patches from PR * Clean up range slider unused variables * Updated Dropdown list to NOT resize text Rect on draw * Upgraded RangeSlider to work in both Horizontal and Verticle setups, just like regular slider. Also fixed a minor issue with offset when dragging on the bar. # Conflicts: # Runtime/Scripts/Controls/RangeSlider.cs * Taking in fix from https://bitbucket.org/UnityUIExtensions/unity-ui-extensions/pull-requests/132 * Applying PR manually, because Bitbucket https://bitbucket.org/UnityUIExtensions/unity-ui-extensions/pull-requests/128 * Merged in fix manually because... Bitbucket https://bitbucket.org/UnityUIExtensions/unity-ui-extensions/pull-requests/130 * Remove old BitBucket Pipeline for GitHub * Fixes issue #398 where the Next / Previous buttons filed to work if the ScrollSnap was previously scrolling. Also renamed the Extension Methods scripts and added a new function. Resolves: #398 * Resolves #397 Moved OnValidate checks which redraw the component to the RectTransformDimensionsCHanged event * Updated UIParticleSystem access to Particles array to ensure it is more stable. Updated some #if statements to be better future proofed Resolves #360 * Fixed the UIConnector to safely handle when no parent canvas can be found. Resolves #392 * Fixed issue which allowed an item marked as NOT transferable to actually be transferred between lists Resolves #382 * Updated #if filter inclusion to 2019_1_OR_Newer resolves: - #411 * Updated UIVertical scroller to be 2022 compliant Resolves: - #410 * Updated Curly UI to wait until end of the frame to recalculate positions Also updated Editor script to work in 2022 Resolves: - #409 * Updated Depth Texture sampler in UI Particles Shaders Resolves: - #401 * Remove meta duplicates for HSVColour Picker * Add newly generated HSV picker meta files * Hard reset of Colour picker guids * Updated Points to always be an array of 1 when set to nothing. Resolves: #295 * Updated Cooldown button to work with Keyboard input Resolves: #171 * Added error handling around setting Unity UI Components for Vertical/Horizontal scrolling Resolves: #296 * Protecting Remove too * Added SetArc method to UICircle as requested Resolves: #280 * Marked ScrollPositionController as Obsolete, users should use the newer Scroller component instead, will be removed in a future release. Resolves: #305 * Updated ScrollPositionControllerEditor as obsolete too * Removed unneeded size calculation which caused some issues with mixed height/width children. Resolves: #380 * Resolved issue whereby the last row in a flow layout group would not size correctly. Resolves: #357 * Updated all components using "LayoutGroup" to override their OnDisable feature to incorporate this fix: https://gist.github.com/randomize/73ca6d3b6aa7210073692eb5cabd537e Resolves: #178 * Checking in new MinMaxSlider TODO - Finish Editor creator * Added Editor Menu Option to create a Min/Max slider Resolves: #270 * Marked TileSizeFitter as obsolete as Unity has made this unworkable Resolves: #214 * Updated Editor create options to add the correct Event System Input module for the Input system used, now or old. Resolves: #378 * Updated Editor menu layout * Updated initialisation logic to not cause an endless loop in the TabNavigationHelper Resolves: #208 * Added new FIFO based UI Line Render when dynamic line rendering is needed (basic, no Beziers) Resolves: #324 * Clean-up of ScrollSnapBase * Updated "Action" use to "UnityAction" to avoid Unity issues Resolves: #253 * Updated UIVerticalScroller for standards and added UIHorizontalScroller Resolves: #205 * Updated ReorderableList/ReorderableListElement to prevent creating a "Fake" droppable when the item is not transferable Resolves: #164 * Updated panel drawing for ComboBox controls and added DropdownOffset Resolves: #393 * Base update for pointers to new version / package home * Cleanup and ensuring the UIParticleSystem is disposed on Destroy correctly. Resolves: #412 * Refresh FancyScrollView with latest fixes * Remove broken examples link * Break Module * Update Examples module to new home * Updating GitHub artifacts and automation * Updated build issue with ReorderableListElement * Revised the Curly UI fix as it was preventing the graphic from being updated in the scene view. Thanks to @solidsign for the update. * Removed legacy Examples link, moving to separate repository * Added new submodule for extracted examples * Fix class spellings and update MultiTouchScrollRect * Updated NonDrawingGraphic to require a CanvasRender, else it causes an error on run (and doesn't work) - Resolves: #420 * Add updated test flow for builds * Fix github issue templates * Add the Version upgrade pipeline * Added ResetSelectableHighlight component * Resolves issue in 2022 with the missing Text component Fixes: #424 * The BIG Unity 2022 Text reorganisation * Remove editor validation and add error checking for the ColorLabel component * Add 2019 to the testing validation * Switch android builds to windows * Several lifetime feature updates for the ComboBox controls: - Resolves startup issue that prevented the control being used (Unity changed the start order in some instances), this was causing null reference issues with comboboxes - Added the ability to set a specific item on start and not just the first - Added the ability to disable the dropdown to make a read-only dropdown Resolves: - #426 - #425 * Resolved issues with DisplayAbove and using a 0 ItemsToDisplay * Update pipelines for release * Final checks for merge! * Auto increment pre-release version to 2.3.0-pre-release.1 [skip ci] * Auto increment pre-release version to 2.3.0-pre-release.2 [skip ci] * Set version to 2.3.0 for initial release * patchfix - erroneous namespace in combobox??? --------- Co-authored-by: Robert Rioja <rrioja@immersivedisplayinc.com> Co-authored-by: Simon Jackson <darkside@xna-uk.net> Co-authored-by: Ben MacKinnon <bilmackinnon@googlemail.com> Co-authored-by: Simon Jackson <sjackson@ethar.com> Co-authored-by: action <action@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Same root cause as issue #410, needs same solution. Presumably other classes are assuming the old Text too.
The text was updated successfully, but these errors were encountered: