fix: contained tokenlist height #531
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
JFrankfurt
reviewed
Mar 3, 2023
src/components/TokenSelect/index.tsx
Outdated
Comment on lines
106
to
109
| style={{ | ||
| minWidth: isPageCentered ? Math.min(400, width) : 'auto', | ||
| minHeight: isPageCentered ? 'unset' : '100%', | ||
| }} |
There was a problem hiding this comment.
can you do this with $isPageCentered as a transient styled-component prop and something like min(400px, 100vw)?
just-toby
force-pushed
the
fix/tokenlist-height-contained
branch
from
ddaec27 to
c57299d
Compare
Screen.Recording.2023-03-03.at.11.50.35.AM.mov |
JFrankfurt
approved these changes
Mar 3, 2023
|
🎉 This PR is included in version 2.44.4 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes a bug where the token list was being cut off in the non-page-centered version of the widget.