Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(sdk-core): fix Rootstock multicall contract address #229

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ahsan-javaiid
Copy link

PR Scope

  • fix(SDK core): fix Rootstock multicall contract address

Description

This PR fixes the multicallAddress for Rootstock network. Please merge and release the sdk. Please also update the sdk-core dependency in https://github.com/Uniswap/smart-order-router after the release.

This is required for implementing smart-order-router for Rootstock network. Thanks

I will make a separate PR in smart-order-router for Rootstock after this PR is published.

How Has This Been Tested?

Locally Tested in https://github.com/Uniswap/smart-order-router.

Are there any breaking changes?

No

(Optional) Feedback Focus

None

(Optional) Follow Ups

None

@ahsan-javaiid ahsan-javaiid requested review from jsy1218 and a team as code owners January 6, 2025 16:33
@ahsan-javaiid
Copy link
Author

cc: @jsy1218 for review and merge.

@ahsan-javaiid ahsan-javaiid force-pushed the fix/rootstock-multicall-address branch from 4cb38b7 to a057578 Compare January 10, 2025 10:28
@ahsan-javaiid ahsan-javaiid force-pushed the fix/rootstock-multicall-address branch from a057578 to 65a962e Compare January 20, 2025 17:35
@ahsan-javaiid
Copy link
Author

@jsy1218
Would be great if you get a chance to merge this PR! Thank you.

@jsy1218
Copy link
Member

jsy1218 commented Jan 23, 2025

@jsy1218 Would be great if you get a chance to merge this PR! Thank you.

@ahsan-javaiid are you guys actually using SOR for RootStock? From our end, we are busy shipping v4 on Uniswap frontend supported networks.

@ahsan-javaiid
Copy link
Author

@jsy1218 Would be great if you get a chance to merge this PR! Thank you.

@ahsan-javaiid are you guys actually using SOR for RootStock? From our end, we are busy shipping v4 on Uniswap frontend supported networks.

Thanks for mentioning this update about v4 shipping on frontend. Is that means SOR will be depricated on frontend? Just asking?

Would like to support Rootstock network on Uniswap frontend that's why i was adding Rootstock support in SOR. Could you please guide me in right direction that what else needed to support Rootstock in frontend like v4 ?

Let me know so that we can support Rootstock on Unsiwap frontend. Lot of users from Rootstock community are asking for that to support Rootstock on Uniswap Frontend.

@jsy1218 Your response will be much appreciated. 🙏

Lastly Rootstock is fully EVM compatible, supported on Alchemy and TheGraph (Uniswap subgraph) as well. Purpose of saying this is to confirm that Rootstock meets the requirements to be supported on Uniswap frontend. Feel free to mention if there are any other requirements or i can send a pull request. Thank you!

I will wait for your response! Thank you! 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants