fix(cache): filter out mixed routes containing protocols not requested for caching ONLY #998
+136
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xrsv
commented
Feb 3, 2025
lib/handlers/router-entities/route-caching/dynamo-route-caching-provider.ts
Show resolved
Hide resolved
Graphite Automations"Request reviewers once CI passes on routing-api repo" took an action on this PR • (02/03/25)4 reviewers were added and 1 assignee was added to this PR based on Siyu Jiang (See-You John)'s automation. |
jsy1218
approved these changes
Feb 3, 2025
cgkol
reviewed
Feb 3, 2025
test/mocha/integ/handlers/router-entities/route-caching/dynamo-route-caching-provider.test.ts
Outdated
Show resolved
Hide resolved
cgkol
changed the title
|
closing in favor of a more complete approach: Uniswap/smart-order-router#820 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Filter out mixed routes containing protocols not requested
Added integration tests