Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: MenuItem without line wrap #7620

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

Holybasil
Copy link

@Holybasil Holybasil commented Nov 27, 2023

Description

Do not wrap menu items, #6265 is fixed too.

Screen capture

Before

Mobile Desktop
CleanShot 2023-11-27 at 16 51 37@2x CleanShot 2023-11-27 at 16 53 10@2x

After

Mobile Desktop
CleanShot 2023-11-27 at 16 52 46@2x CleanShot 2023-11-27 at 16 53 35@2x

Reproducing the error

  1. set language to 简体中文

@Holybasil Holybasil requested review from a team and just-toby November 27, 2023 08:35
Copy link

vercel bot commented Nov 27, 2023

@Holybasil is attempting to deploy a commit to the Uniswap Team on Vercel.

A member of the Team first needs to authorize it.

@Holybasil
Copy link
Author

@kristiehuang would appreciate it if you can take a look

@zzmp zzmp added the reference Reference PR label Nov 28, 2023
Copy link

codecov bot commented Nov 28, 2023

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (fc7ecc7) 43.59% compared to head (49e151c) 43.66%.
Report is 7 commits behind head on main.

❗ Current head 49e151c differs from pull request most recent head 7c02e00. Consider uploading reports for the commit 7c02e00 to get more accurate results

Flag Coverage Δ
cloud-tests 83.60% <ø> (ø)
unit-tests 43.56% <0.00%> (+0.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@Holybasil Holybasil reopened this Dec 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
reference Reference PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants