fix: remove base goerli from chain selector #7238
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Codecov Report
Flags with carried forward coverage won't be shown. Click here to find out more. |
Passing run #14043 ↗︎
Details:
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. |
|||||||||||||||
zzmp
suggested changes
Aug 29, 2023
that's fair, we can remove them all and still just revert this PR when the time is right. |
just-toby
force-pushed
the
fix/remove-base-goerli
branch
from
39c4588 to
c8e2909
Compare
zzmp
approved these changes
Aug 29, 2023
gnewfield
approved these changes
Aug 29, 2023
abarthell
added a commit
to abarthell/widgets
that referenced
this pull request
Sep 14, 2023
abarthell
added a commit
to abarthell/widgets
that referenced
this pull request
Sep 14, 2023
abarthell
added a commit
to abarthell/widgets
that referenced
this pull request
Sep 14, 2023
just-toby
pushed a commit
to Uniswap/widgets
that referenced
this pull request
Sep 25, 2023
* Add Base support to Uniswap widget * Remove Base Goerli until routing supports it: Uniswap/interface#7238 * Bump uniswap/default-token-lists to 11.6.0 * update blockWaitMs and rpc endpoints * Add Multicall and Swap Souter address * Fix linting * Additional fixes * Bump smart-order-router to v3.16.25 * Bump deps * Ran yarn deduplicate
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
remove base testnet until routing supports it
Slack thread: https://uniswapteam.slack.com/archives/C03ESADBQPK/p1693248493220419
Test plan
verify that base goerli no longer appears in the chain selector with testnets enabled (in settings)