Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Copy new version to event varmap on sw/hw/fw upgrade #2545

Merged

Conversation

johannaengland
Copy link
Contributor

As mentioned by @lunkwill42 in #2515 (comment) the new version for a sw/hw/fw upgrade should also be saved in the event varmap in the same place as the old version.

@johannaengland johannaengland self-assigned this Jan 6, 2023
@sonarqubecloud
Copy link

sonarqubecloud bot commented Jan 6, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@codecov
Copy link

codecov bot commented Jan 6, 2023

Codecov Report

Merging #2545 (8f35680) into master (2d7b2a0) will decrease coverage by 0.03%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master    #2545      +/-   ##
==========================================
- Coverage   53.39%   53.36%   -0.04%     
==========================================
  Files         555      555              
  Lines       40361    40361              
==========================================
- Hits        21552    21539      -13     
- Misses      18809    18822      +13     
Impacted Files Coverage Δ
python/nav/ipdevpoll/shadows/__init__.py 42.64% <0.00%> (ø)
python/nav/ipdevpoll/pool.py 84.88% <0.00%> (-5.04%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@github-actions
Copy link

github-actions bot commented Jan 6, 2023

Test results

     12 files       12 suites   10m 28s ⏱️
3 184 tests 3 088 ✔️   96 💤 0
9 027 runs  8 739 ✔️ 288 💤 0

Results for commit 8f35680.

Copy link
Member

@lunkwill42 lunkwill42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Made a separate issue for the wonky coverage report.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants