Add non-minimal pre-commit config #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johannaengland
requested changes
Feb 10, 2023
I wouldn't call a pre-commit with black "minimal" :)
Willdo. |
johannaengland
requested changes
Feb 10, 2023
There was a problem hiding this comment.
I was more thinking to do it the way it is mentioned in the Argus README (https://github.com/Uninett/Argus#code-style) for consistency and to also explain very shortly how to enable the pre-commit
|
I do not have the brains for mind-reading today, and I'm once again out of caffeine. Please update (or close) the PR as you see fit. This is just polish, a nice to have. The important one, #13, has already been merged. |
johannaengland
changed the title
hmpf
commented
Feb 13, 2023
lunkwill42
approved these changes
Feb 17, 2023
johannaengland
force-pushed
the
add-precommit
branch
from
8a84755 to
8497a2d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.