Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document how to install everything manually on Debian #50

Merged
merged 4 commits into from
Jan 26, 2024
Merged

Document how to install everything manually on Debian #50

merged 4 commits into from
Jan 26, 2024

Conversation

hmpf
Copy link
Contributor

@hmpf hmpf commented Jan 18, 2024

@hmpf hmpf requested a review from podliashanyk January 18, 2024 13:55
@hmpf hmpf self-assigned this Jan 18, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 18, 2024 •
edited
Loading

Test results

  4 files    4 suites   8s ⏱️
14 tests 14 ✔️ 0 💤 0 ❌
56 runs  56 ✔️ 0 💤 0 ❌

Results for commit b3d7b6a.

♻️ This comment has been updated with latest results.

@codecov-commenter
Copy link

codecov-commenter commented Jan 18, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ No coverage uploaded for pull request base (main@a28c7f7). Click here to learn what that means.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main      #50   +/-   ##
=======================================
  Coverage        ?   50.50%           
=======================================
  Files           ?       15           
  Lines           ?      796           
  Branches        ?        0           
=======================================
  Hits            ?      402           
  Misses          ?      394           
  Partials        ?        0

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hmpf hmpf added documentation Improvements or additions to documentation help wanted Extra attention is needed deployment labels Jan 18, 2024
@hmpf hmpf force-pushed the installation-docs branch 4 times, most recently from e50119a to a0a70c4 Compare January 24, 2024 09:43
johannaengland
johannaengland reviewed Jan 25, 2024
View reviewed changes
Copy link
Contributor

@johannaengland johannaengland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have not tried it out, only did some proofreading

docs/source/install-on-debian.rst Outdated Show resolved Hide resolved
docs/source/install-on-debian.rst Outdated Show resolved Hide resolved
docs/source/install-on-debian.rst Outdated Show resolved Hide resolved
docs/source/install-on-debian.rst Show resolved Hide resolved
@hmpf hmpf force-pushed the installation-docs branch from a0a70c4 to 5af6691 Compare January 26, 2024 10:37
@hmpf hmpf requested a review from johannaengland January 26, 2024 10:37
lunkwill42
lunkwill42 requested changes Jan 26, 2024
View reviewed changes
Copy link
Member

@lunkwill42 lunkwill42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty comprehensive to me :) I've read it, but I haven't test-driven it.

docs/source/install-on-debian.rst Outdated Show resolved Hide resolved
docs/source/install-on-debian.rst Outdated Show resolved Hide resolved
docs/source/install-on-debian.rst Outdated Show resolved Hide resolved
docs/source/install-on-debian.rst Outdated Show resolved Hide resolved
docs/source/install-on-debian.rst Outdated Show resolved Hide resolved
@hmpf hmpf force-pushed the installation-docs branch from 5af6691 to 27916dc Compare January 26, 2024 11:31
@hmpf hmpf requested a review from lunkwill42 January 26, 2024 11:47
lunkwill42
lunkwill42 approved these changes Jan 26, 2024
View reviewed changes
Copy link
Member

@lunkwill42 lunkwill42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good enough for me. Will maybe have to do a run-through some other day, the weekend is looming :)

@hmpf hmpf merged commit ed2b0f3 into Uninett:main Jan 26, 2024
5 checks passed
@hmpf hmpf deleted the installation-docs branch January 26, 2024 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lunkwill42 lunkwill42 lunkwill42 approved these changes

@podliashanyk podliashanyk Awaiting requested review from podliashanyk

@stveit stveit Awaiting requested review from stveit

@johannaengland johannaengland Awaiting requested review from johannaengland

Assignees

@hmpf hmpf

Labels
deployment documentation Improvements or additions to documentation help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@hmpf @codecov-commenter @lunkwill42 @johannaengland