-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve incidents file-path naming and template locations #1098
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Import paths have to be fixed in following files:
src/argus/htmx/urls.py
src/argus/htmx/themes/views.py
src/argus/htmx/dateformat/views.py
src/argus/htmx/user/views.py
Another updates necessary:
ARGUS_HTMX_FILTER_FUNCTION = "argus.htmx.incident.filter.incident_list_filter"
insrc/argus/htmx/defaults.py
Should we also singularize some of the path names in src/argus/htmx/incident/urls.py
?
src/argus/htmx/templates/htmx/incident/cells/_incident_combined_status.html
Outdated
Show resolved
Hide resolved
Urk, you mean my grep-fu has failed me? Bah.
Do you mean
to
Sure. |
Those were tricky ones 😄
Yes! |
Remember to also move |
44ce735
to
6043b18
Compare
It is generic.
9517654
to
7405508
Compare
Quality Gate passedIssues Measures |
This is, and should be, a pure refactor.
This changes
incident*s*
toincident
in directory names and moves a subset of templates in thetemplates/htmx/incident/
directory so that the structure is easier to understand.Reading commit by commit is probably best.
Do come with suggestions for other renames/moves in the
templates/htmx/incident/
directory.