-
Notifications
You must be signed in to change notification settings - Fork 262
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
netCDF4 should error when assigning multi-dimensional arrays as attributes #841
Comments
Agreed - this is a bug. Will submit a PR. |
I hope no one is depending on this behavior. Maybe we should issue a FutureWarning instead, and change it to ValueError in the next release. |
Note that |
A FutureWarning sounds like a good choice for now.
…On Wed, Aug 29, 2018 at 12:13 PM Jeff Whitaker ***@***.***> wrote:
Note that nc.foo = ['multi', 'dimensional'] produces [u'multi',
u'dimensional'] in master, so this PR will have no affect for this case.
However nc.foo = [['multi'], ['dimensional']] will now raise a ValueError.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#841 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABKS1iB3GOnB0PFrOZLedGPHXfBgNUxRks5uVufKgaJpZM4WR3bj>
.
|
changed pull request #842 to FutureWarning |
raise ValueError when trying to set multi-dim array att (issue #841)
pull request #824 merged. FutureWarning will change to ValueError in 1.4.3 |
Right now, they are silently flattened:
This was reported downstream by an xarray user: pydata/xarray#2251
The text was updated successfully, but these errors were encountered: