Refactor classes for atomic types #146
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See following C++ Core Guidelines for rationale: - https://isocpp.github.io/CppCoreGuidelines/CppCoreGuidelines#c20-if-you-can-avoid-defining-default-operations-do - https://isocpp.github.io/CppCoreGuidelines/CppCoreGuidelines#c21-if-you-define-or-delete-any-copy-move-or-destructor-function-define-or-delete-them-all
- make ctors all inline - use intermediate class `NcAtomic` to reduce duplication of equality operator - now classes are only a few lines each, move them all into `ncType.h` header
ZedThree
force-pushed
the
type-classes-refactor
branch
from
0a6d0f1
to
7251d6c
Compare
|
Reviewing the CXX PR's, I have some work to do with the cxx4 CI, e.g. 'add some'. Once I have that in place I will be able to go through and merge the PR's you've submitted. Thanks! |
|
Did you see #139? It adds some basic CI
…On Tue, 23 Jan 2024, 19:36 Ward Fisher, ***@***.***> wrote:
Reviewing the CXX PR's, I have some work to do with the cxx4 CI, e.g. 'add
some'. Once I have that in place I will be able to go through and merge the
PR's you've submitted. Thanks!
—
Reply to this email directly, view it on GitHub
<#146 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AALLAXW3ZH3SAYEC233INYDYQAGKVAVCNFSM6AAAAABBNFNX6KVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMBWG44TINZYGE>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NcAtomicto reduce duplication of equality operatorncType.hheaderIncludes #144. In total this removes ~1k lines