Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

extra tests, plus fill value fixes for string type #821

Conversation

edhartnett
Copy link
Contributor

@edhartnett edhartnett commented Jan 30, 2018

This contains extra tests, and fixes for the fill values of strings.

Also contains the rename tests, including a couple of commented out lines which show where some rename problems remain.

Fixes #727.
Fixes #732.

@edhartnett
Copy link
Contributor Author

The failure we are seeing is this:

The following tests FAILED:
	127 - nc_test4_tst_hdf4_read_var (Failed)

Yet this test does not include hdf4 as far as I can tell, so I don't know what is going on.

I suspect this has something to do with tst_interops2 and parallel builds. I'm not sure that the CMakeLists.txt is correct in how tst_interops2. It has the following:

IF(USE_HDF4_FILE_TESTS AND NOT MSVC)
    add_bin_test_no_prefix(tst_interops2)
    build_bin_test_no_prefix(tst_interops3)
    add_sh_test(nc_test4 run_get_hdf4_files)
    add_bin_test(nc_test4 tst_bug324)
    add_sh_test(nc_test4 tst_formatx_hdf4)
    build_bin_test(tst_chunk_hdf4)
    add_sh_test(nc_test4 run_chunk_hdf4)
    add_bin_test(nc_test4 tst_h4_lendian)
    add_sh_test(nc_test4 tst_hdf4_read_var)
    SET_TESTS_PROPERTIES(nc_test4_tst_hdf4_read_var PROPERTIES DEPENDS tst_interops2)
ENDIF()

tst_interops2 must run before tst_hdf4_read_var.sh. The SET_TESTS_PROPERTIES should assure this.

For other C tests that are run from shell scripts, we stopped trying to track dependencies between the running of the C program and the shell script. I instead changed the shell scripts to run the C programs directly, and then the build system just has to make sure the C program is built before the shell script is run. This turns out to be a lot simpler and easier.

I'm not sure what is going on with tst_interops2. I think we should probably do the same with it as we do with the other C test programs that are checked by shell script.

@edhartnett
Copy link
Contributor Author

I retriggered a build, but a bunch of them timed out. I will leave this and let Ward re-run tests when it is near merging.

@WardF WardF merged commit dff3472 into Unidata:master Feb 7, 2018
@edhartnett edhartnett deleted the ejh_fill_value_string_unidata branch May 14, 2018 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants