Fix some bad parameter bugs in type functions, add documentation and testing #780
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…fined types, fixed check of return value
This was referenced Jan 18, 2018
|
These changes are now part of #788 so I will close this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While waiting for other PRs to be merged, I took a stab at improving the testing of nc4type.c, currently the lowest tested file in libsrc4 with 65% test coverage.
While adding tests I found and fixed a few problems, including SEGFAULT if NULL is passed for name parameter when adding a user-defined type.
Also fixed bug in nc_inq_type_equal() relating to uncommitted types. Documented the tricky behavior of this function with uncommitted user-defined types.
Also also added a bunch of extra tests. ;-)
Part of #701.
Fixes #779.
Fixes #777.
Fixes #776.
Fixes #775.
Fixes #774.