Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix "applying non-zero offset 4 to null pointer" UB #3081

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

vitalybuka
Copy link

@vitalybuka vitalybuka commented Jan 29, 2025

Detected with

cmake .. -GNinja \
  -DCMAKE_C_FLAGS="-fsanitize=pointer-overflow -fno-sanitize-trap=pointer-overflow -fno-sanitize-recover=pointer-overflow" \
  -DCMAKE_CXX_FLAGS="-fsanitize=pointer-overflow -fno-sanitize-trap=pointer-overflow -fno-sanitize-recover=pointer-overflow" \
  -DCMAKE_EXE_LINKER_FLAGS="-fsanitize=pointer-overflow" -DCMAKE_C_COMPILER=clang -DCMAKE_CXX_COMPILER=clang++

ninja
ninja test

Detected with
```
cmake .. -GNinja \
  -DCMAKE_C_FLAGS="-fsanitize=pointer-overflow -fno-sanitize-trap=pointer-overflow -fno-sanitize-recover=pointer-overflow" \
  -DCMAKE_CXX_FLAGS="-fsanitize=pointer-overflow -fno-sanitize-trap=pointer-overflow -fno-sanitize-recover=pointer-overflow" \
  -DCMAKE_EXE_LINKER_FLAGS="-fsanitize=pointer-overflow" -DCMAKE_C_COMPILER=clang -DCMAKE_CXX_COMPILER=clang++

ninja
ninja test
```
@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@schwehr
Copy link

schwehr commented Jan 29, 2025

I am working on the CLA signature within Google. It might take a while to get through the whole process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants