Removed a use of sprintf that required changing a function signature

[seanm]

No description provided.

[seanm]

How does NetCDF deal with deprecating and replacing APIs? i.e. for this part:

-extern void cdRel2Iso(cdCalenType timetype, char* relunits, int separator, double reltime, char* chartime);
+extern void cdRel2IsoNew(cdCalenType timetype, char* relunits, int separator, double reltime, char* chartime, size_t chartime_size);
+extern void cdRel2Iso(cdCalenType timetype, char* relunits, int separator, double reltime, char* chartime); // deprecated

What shall we call the new API? cdRel2IsoNew is just a placeholder.

Do you have a deprecation macro that does similar to C23's [[deprecated]]? If not, I can add one.

Thanks.

[DennisHeimbigner]

I do not think this function change is a problem.
The change has no material affect on its operation.
The function is not part of the netcdf API (as defined in the
include/netcdfXXX.h files).

[seanm]

Ah, I thought it might have been public API. Patch updated.

[DennisHeimbigner]

There is one other point. If memory serves, the nctime code was taken from some other site.
It is possible that if this site is still being updated, that we should consider updating out code
to match. This might obviate the need for this change.

[seanm]

I've done some searching and tried to find an upstream, but most searches just bring me to netcdf.

[seanm]

@DennisHeimbigner I've just tried again, but can't find any upstream. Closest I got is: https://cdat.llnl.gov/

if that's it, they aren't maintaining it anymore anyway.

[seanm]

Rebased with latest main.

@WardF @DennisHeimbigner this one is ready to merge IMHO, pending your reviews.