-
Notifications
You must be signed in to change notification settings - Fork 262
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade the nczarr code to match Zarr V2 #1990
Merged
Merged
Commits on Apr 25, 2021
-
Upgrade the nczarr code to match Zarr V2
Re: zarr-developers/zarr-python#716 The Zarr version 2 spec has been extended to include the ability to choose the dimension separator in chunk name keys. The legal separators has been extended from {'.'} to {'.' '/'}. So now it is possible to use a key like "0/1/2/0" for chunk names. This PR implements this for NCZarr. The V2 spec now says that this separator can be set on a per-variable basis. For now, I have chosen to allow this be set only globally by adding a key named "ZARR.DIMENSION_SEPARATOR=<char>" in the .daprc/.dodsrc/ncrc file. Currently, the only legal separator characters are '.' (the default) and '/'. On writing, this key will only be written if its value is different than the default. This change caused problems because supporting a separator of '/' is difficult to parse when keys/paths use '/' as the path separator. A test case was added for this. Additionally, make nczarr be enabled default by default. This required some additional changes so that if zip and/or AWS S3 sdk are unavailable, then they are disabled for NCZarr. In addition the following unrelated changes were made. 1. Tested that pure-zarr mode could read an nczarr formatted store. 1. The .rc file handling now merges all known .rc files (.ncrc,.daprc, and .dodsrc) in that order and using those in HOME first, then in current directory. For duplicate entries, the later ones override the earlier ones. This change is to remove some of the conflicts inherent in the current .rc file load process. A set of test cases was also added. 1. Re-order tests in configure.ac and CMakeLists.txt so that if libcurl is not found then the other options that depend upon it properly are disabled. 1. I decided that xarray support should be enabled by default for pure zarr. In order to allow disabling, I added a new mode flag "noxarray". 1. Certain test in nczarr_test depend on use of .dodsrc. In order for these to work when testing in parallel, some inter-test dependencies needed to be added. 1. Improved authorization testing to use changes in thredds.ucar.edu
Configuration menu - View commit details
-
Copy full SHA for 74b40fd - Browse repository at this point
Copy the full SHA 74b40fdView commit details -
Configuration menu - View commit details
-
Copy full SHA for 6ef0226 - Browse repository at this point
Copy the full SHA 6ef0226View commit details -
Configuration menu - View commit details
-
Copy full SHA for f3d118b - Browse repository at this point
Copy the full SHA f3d118bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 05b4046 - Browse repository at this point
Copy the full SHA 05b4046View commit details -
Configuration menu - View commit details
-
Copy full SHA for ed70a2e - Browse repository at this point
Copy the full SHA ed70a2eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 1f51ec5 - Browse repository at this point
Copy the full SHA 1f51ec5View commit details -
Configuration menu - View commit details
-
Copy full SHA for dec9e74 - Browse repository at this point
Copy the full SHA dec9e74View commit details
Commits on Apr 26, 2021
-
Configuration menu - View commit details
-
Copy full SHA for 1243c3d - Browse repository at this point
Copy the full SHA 1243c3dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 5873c62 - Browse repository at this point
Copy the full SHA 5873c62View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.