Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade the nczarr code to match Zarr V2 #1990

Merged
merged 9 commits into from
Apr 26, 2021

Commits on Apr 25, 2021

  1. Upgrade the nczarr code to match Zarr V2

    Re: zarr-developers/zarr-python#716
    
    The Zarr version 2 spec has been extended to include the ability
    to choose the dimension separator in chunk name keys. The legal
    separators has been extended from {'.'} to {'.' '/'}.  So now it
    is possible to use a key like "0/1/2/0" for chunk names.
    
    This PR implements this for NCZarr. The V2 spec now says that
    this separator can be set on a per-variable basis. For now, I
    have chosen to allow this be set only globally by adding a key
    named "ZARR.DIMENSION_SEPARATOR=<char>" in the
    .daprc/.dodsrc/ncrc file. Currently, the only legal separator
    characters are '.' (the default) and '/'. On writing, this key
    will only be written if its value is different than the default.
    This change caused problems because supporting a separator of '/'
    is difficult to parse when keys/paths use '/' as the path separator.
    A test case was added for this.
    
    Additionally, make nczarr be enabled default by default. This required
    some additional changes so that if zip and/or AWS S3 sdk are unavailable,
    then they are disabled for NCZarr.
    
    In addition the following unrelated changes were made.
    
    1. Tested that pure-zarr mode could read an nczarr formatted store.
    1. The .rc file handling now merges all known .rc files (.ncrc,.daprc, and .dodsrc) in that order and using those in HOME first, then in current directory. For duplicate entries, the later ones override the earlier ones. This change is to remove some of the conflicts inherent in the current .rc file load process. A set of test cases was also added.
    1. Re-order tests in configure.ac and CMakeLists.txt so that if libcurl
       is not found then the other options that depend upon it properly
       are disabled.
    1. I decided that xarray support should be enabled by default for pure
       zarr. In order to allow disabling, I added a new mode flag "noxarray".
    1. Certain test in nczarr_test depend on use of .dodsrc. In order for these
       to work when testing in parallel, some inter-test dependencies needed to
       be added.
    1. Improved authorization testing to use changes in thredds.ucar.edu
    DennisHeimbigner committed Apr 25, 2021
    Configuration menu
    Copy the full SHA
    74b40fd View commit details
    Browse the repository at this point in the history
  2. Update RELEASE NOTES

    DennisHeimbigner committed Apr 25, 2021
    Configuration menu
    Copy the full SHA
    6ef0226 View commit details
    Browse the repository at this point in the history
  3. reset action signals

    DennisHeimbigner committed Apr 25, 2021
    Configuration menu
    Copy the full SHA
    f3d118b View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    05b4046 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    ed70a2e View commit details
    Browse the repository at this point in the history
  6. LGTM cleanup

    DennisHeimbigner committed Apr 25, 2021
    Configuration menu
    Copy the full SHA
    1f51ec5 View commit details
    Browse the repository at this point in the history
  7. logdepend

    DennisHeimbigner committed Apr 25, 2021
    Configuration menu
    Copy the full SHA
    dec9e74 View commit details
    Browse the repository at this point in the history

Commits on Apr 26, 2021

  1. Configuration menu
    Copy the full SHA
    1243c3d View commit details
    Browse the repository at this point in the history
  2. remove push signal

    DennisHeimbigner committed Apr 26, 2021
    Configuration menu
    Copy the full SHA
    5873c62 View commit details
    Browse the repository at this point in the history