provide NDEBUG version of macro NC_CHECK which does not use code file name #1326
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The question is: does it fix the problem? |
|
Well I hope it will fix some of them. @sebastic can you build this branch and see how many of the warnings it clears up? |
|
It solved the issue for |
DennisHeimbigner
added a commit
that referenced
this pull request
Feb 17, 2019
re: issue #1323 and PR #1326 Replace the uses of the __FILE__ macro in ncgen with the constant string "ncgen" in order to keep external package builders (like Debian) happy. Note that __FILE__ will still appear in ncgen generated C code files, but this should be ok since it is not part of the distro per-se.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #1323.
Provide NDEBUG version of macro NC_CHECK which does not use code file name.