Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

set NAWIPS to path holding Gemenviron by default #85

Merged
merged 1 commit into from
Apr 13, 2022

Conversation

akrherz
Copy link
Collaborator

@akrherz akrherz commented Mar 21, 2022

see #57

@akrherz
Copy link
Collaborator Author

akrherz commented Mar 21, 2022

Any bash/csh experts out there? Please review this PR and chime in with your opinions!

@akrherz akrherz added this to the 7.14.0.2 milestone Mar 21, 2022
@mzuranski
Copy link
Contributor

@akrherz FYI I also opened #80 to isolate this topic from the rest of #57

@sgdecker
Copy link
Collaborator

I know in bash it can be notoriously tricky to handle all the edge cases, but off hand I don't see why the cd -- and && pwd parts are needed. In other words, why isn't dirname good enough? But I am no bash expert.

@akrherz
Copy link
Collaborator Author

akrherz commented Mar 21, 2022

Yeah @sgdecker, that's a fair question and perhaps I am over-engineering here. I am worried about symlinks being used, but perhaps that is not justified.

@sgdecker
Copy link
Collaborator

@akrherz For the record, I dumped the Gemenviron.profile file from this branch into ShellCheck, and it found plenty to complain about it, but the specific line in question here was fine. It's probably OK either way.

@akrherz
Copy link
Collaborator Author

akrherz commented Mar 28, 2022

@sgdecker Thanks, I did not know about shellcheck! I'll take this PR in a few days unless anybody objects!

@akrherz akrherz merged commit d8a6850 into Unidata:main Apr 13, 2022
@akrherz akrherz deleted the gh57_set_nawips branch April 13, 2022 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants