Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add handle ndarray to angle_do_direction #3445

Closed

Conversation

raybellwaves
Copy link
Contributor

@raybellwaves raybellwaves requested a review from a team as a code owner March 18, 2024 18:40
@raybellwaves raybellwaves requested review from dopplershift and removed request for a team March 18, 2024 18:40
@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


Ray Bell seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@dopplershift
Copy link
Member

@raybellwaves Looks good. I see now that @preprocess_and_wrap() wasn't working quite right. Looks like there's something weird in the commit? Wrong account?

@raybellwaves
Copy link
Contributor Author

@raybellwaves Looks good. I see now that @preprocess_and_wrap() wasn't working quite right. Looks like there's something weird in the commit? Wrong account?

Not sure. I'm going to pause work here. Created some thoughts at #3444 (comment)

@raybellwaves
Copy link
Contributor Author

Shall I close this and hope the commit works in another (clean) PR?

@dopplershift
Copy link
Member

I'm happy to merge this if you can fix up the commit info. It looks like the commit on this PR is authored with your DTN email, while your other PR used your gmail address that's listed on your GitHub account. I'm guessing your DTN address isn't affiliated with your GitHub account, which is why the CLA checker says:

Ray Bell seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.

If you want to fix it, an easy way is to:

git reset --soft HEAD~1 and recommit the changes with git properly configured.

@raybellwaves
Copy link
Contributor Author

Thanks for the advice ended up opening a new PR: #3448 apologies.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cast angle_to_direction to input array type
3 participants