Generalize testing version comparison #3271
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dcamron
added
Type: Maintenance
|
Given all the line length issues, how do we feel about |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
I didn't see this before I cleaned up the lint. I don't feel strongly about the name either way! |
dopplershift
reviewed
Nov 9, 2023
|
Looks like the new "strict" setting requires us to adjust the "fails" criteria for the moist_lapse fail test. Also, let's go with the shorter names. |
dopplershift
reviewed
Nov 9, 2023
dopplershift
requested changes
Nov 14, 2023
|
Need to also rebase this on main to deal with the conflict (due to |
Simplify one more time down to a single version comparison helper that parses a package spec string and compares that spec to the currently installed package.
dcamron
force-pushed
the
version-compare
branch
4 times, most recently
from
eae8657 to
9859e93
Compare
Add validation to requested package spec to fail if the spec is out of date and irrelevant according to package metadata.
dcamron
force-pushed
the
version-compare
branch
from
9859e93 to
3ec60ca
Compare
dopplershift
requested changes
Nov 14, 2023
Co-authored-by: Ryan May <rmay31@gmail.com>
dopplershift
approved these changes
Nov 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Expand our testing version comparison helper to support testing conditions for any dependency.