Adjust user-provided parcel temperature profile for NaN values in EL and LFC #3056
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ve the NaN mask properly applied.
dopplershift
added
Type: Bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
EL and LFC are functions that take a pressure profile, temperature profile, dewpoint profile, and an optional parcel temperature profile. When a missing value (np.NaN) is found in any of the profiles, the data point is removed, along with the data point at that level in all the other profiles as well.
A bug described in #2921 shows that a missing value in any of the ambient profiles did not lead to the removal of a data point in the optional parcel temperature profile (when the user chose to provide that optional profile).
This PR introduces some rearrangements to the EL and LFC calculations to resolve that issue. Four new tests for NaN values in these calculations are also added.
Checklist