CI: Swap over to PyPI trusted publishing #3019
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of using a fixed, shared API secret key, you configure a GitHub actions workflow (and environment) on PyPI to be allowed to publish to the project. Through this GitHub and PyPI exhange short-lived tokens for publication.
dcamron
approved these changes
Apr 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description Of Changes
Instead of using a fixed, shared API secret key, you configure a GitHub actions workflow (and environment) on PyPI to be allowed to publish to the project. Through this GitHub and PyPI exhange short-lived tokens for publication. Thankfully this is automatic when using the PyPA publication action that we've already been using.
I've already deactivated the previous API key (which was tied to my personal PyPI account) and removed it from our GitHub configs. Another benefit of this is that everything is tied to project infrastructure rather than individual users.
I've already configured our PyPI project to use our GitHub actions workflow and environment.