Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use weighted_continuous_average in bunkers_storm_motion #2999

Merged
merged 3 commits into from
May 3, 2023
Merged

Use weighted_continuous_average in bunkers_storm_motion #2999

merged 3 commits into from
May 3, 2023

Conversation

dcamron
Copy link
Member

@dcamron dcamron commented Apr 7, 2023 •
edited
Loading

From recent discussions and #2092 (comment), a quick update to use weighted_continuous_average in bunkers_storm_motion for the layer wind averages instead of np.mean. Opening this up to any discussion before updating any test values (and making sure a small change works back to Minimum.)

Checklist

@dcamron dcamron added Type: Maintenance Updates and clean ups (but not wrong) Area: Calc Pertains to calculations labels Apr 7, 2023
@dcamron dcamron added this to the April 2023 milestone Apr 7, 2023
@dcamron dcamron requested a review from a team as a code owner April 7, 2023 22:56
@dcamron dcamron requested review from dopplershift and removed request for a team April 7, 2023 22:56
dopplershift
dopplershift reviewed Apr 10, 2023
View reviewed changes
Copy link
Member

@dopplershift dopplershift left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm happy with this. I'm curious how bad the test value changes are...I would hope they're not significant.

@dcamron
Copy link
Member Author

dcamron commented Apr 10, 2023

I'm happy with this. I'm curious how bad the test value changes are...I would hope they're not significant.

Max absolute difference: 0.37513416
Max relative difference: 0.11791906
 x: array([ 2.062733  ,  0.96246913, 11.22554254, 12.83861839,  6.64413777,
        6.90054376])
 y: array([ 2.18346161,  0.86094706, 11.6006767 , 12.53639395,  6.89206916,
        6.69867051])

@dopplershift
Copy link
Member

Probably a little bigger than I'd like (percentage-wise) but not really scary.

@dopplershift
Copy link
Member

@dcamron Do you want to fix up the tests to get this in the release?

@dcamron
Copy link
Member Author

dcamron commented Apr 28, 2023

If there's no other community input and we feel good about these changes, I'm glad to.

@dcamron dcamron requested a review from dopplershift May 3, 2023 16:31
@dopplershift dopplershift merged commit 64608b0 into Unidata:main May 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dopplershift dopplershift dopplershift approved these changes

Assignees
No one assigned
Labels
Area: Calc Pertains to calculations Type: Maintenance Updates and clean ups (but not wrong)
Projects
None yet
Milestone
1.5.0
Development

Successfully merging this pull request may close these issues.

Add non-weighted pressure-based mean function
2 participants
@dcamron @dopplershift