Improve default BarbPlot zorder #2752
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dopplershift
added
Type: Bug
|
I also hadn't noticed the barbs behind contours and that is likely because I do barbs in black and height contours in black, which then one can't really tell which is on top or bottom! This seems like a sensible solution. |
dopplershift
force-pushed
the
barb-zorder
branch
from
5a4808c to
3eb21d6
Compare
Previously, the barbs would end up "lower" in the draw stack than the lakes map overlay, as well as behind contour lines. This sets a zorder of 2, which is enough to address both of these.
dopplershift
force-pushed
the
barb-zorder
branch
from
3eb21d6 to
85d8b8c
Compare
dcamron
approved these changes
Oct 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description Of Changes
Previously, the barbs would end up "lower" in the draw stack than the lakes map overlay, as well as behind contour lines. This sets a zorder of 2, which is enough to address both of these.
I hadn't noticed barbs went behind contours before. I don't think that's what we want?
Checklist