Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add left and right title option #2645

Merged
merged 2 commits into from
Sep 16, 2022
Merged

add left and right title option #2645

merged 2 commits into from
Sep 16, 2022

Conversation

kgoebber
Copy link
Collaborator

@kgoebber kgoebber commented Sep 3, 2022 •
edited by dopplershift
Loading

Description Of Changes

This PR adds the ability to have right and left location titles in the declarative syntax.

Checklist

@kgoebber kgoebber requested a review from a team as a code owner September 3, 2022 22:52
@kgoebber kgoebber requested review from dcamron and removed request for a team September 3, 2022 22:52
dopplershift
dopplershift requested changes Sep 15, 2022
View reviewed changes
Copy link
Member

@dopplershift dopplershift left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a minor tweak to the test to get all of the titles. I was going to ask you to regenerate with the testing build anyway. 😉

Otherwise, this looks great!

tests/plots/test_declarative.py Show resolved Hide resolved
@dopplershift dopplershift added Type: Feature New functionality Area: Plots Pertains to producing plots labels Sep 15, 2022
@dopplershift dopplershift added this to the September 2022 milestone Sep 15, 2022
@kgoebber kgoebber force-pushed the add_other_title_plots branch from 271083a to 6992e48 Compare September 16, 2022 00:57
@dopplershift dopplershift merged commit eb0efa1 into Unidata:main Sep 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dopplershift dopplershift dopplershift approved these changes

@dcamron dcamron Awaiting requested review from dcamron dcamron is a code owner automatically assigned from Unidata/metpy-maintainers

Assignees
No one assigned
Labels
Area: Plots Pertains to producing plots Type: Feature New functionality
Projects
Python
Status: Done
Milestone
1.4.0
Development

Successfully merging this pull request may close these issues.
2 participants
@kgoebber @dopplershift